Prep to remove excluded projects trigger exclusion #81264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Contributor
|
This PR has a migration; here is the generated SQL for --
-- Moved model AlertRuleExcludedProjects to pending deletion state
--
-- (no-op)
--
-- Moved model AlertRuleTriggerExclusion to pending deletion state
--
-- (no-op) |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #81264 +/- ##
==========================================
- Coverage 80.35% 80.35% -0.01%
==========================================
Files 7221 7221
Lines 319612 319589 -23
Branches 20783 20783
==========================================
- Hits 256821 256795 -26
- Misses 62396 62399 +3
Partials 395 395 |
wedamija
approved these changes
Nov 25, 2024
Member
|
Probably need to update snapshots and so on |
ceorourke
force-pushed
the
ceorourke/rm-excluded-projects
branch
from
e969dcf to
d701ebf
Compare
github-actions
bot
added
the
Scope: Frontend
Contributor
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Dec 2, 2024
Follow up to #81020 (and a few others) to remove the `AlertRuleExcludedProjects` and `AlertRuleTriggerExclusion` models. There will be a final PR to fully remove them and then they're finally gone!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #81020 (and a few others) to remove the
AlertRuleExcludedProjectsandAlertRuleTriggerExclusionmodels. There will be a final PR to fully remove them and then they're finally gone!