chore(alerts): Remove incident activity comments #81386
Conversation
github-actions
bot
added
the
Scope: Backend
| incident=incident, | ||
| status=result["status"], | ||
| user=serialize_generic_user(request.user), | ||
| comment=result.get("comment"), |
There was a problem hiding this comment.
This is the only call to update_incident_status that passes user and comment so I checked the API access logs to confirm the only usage is by customers who are probably using it to close incidents. I also ensured that we haven't sent the incident activity emails just in case a customer was for some reason using that part of it.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #81386 +/- ##
==========================================
- Coverage 80.37% 80.37% -0.01%
==========================================
Files 7231 7230 -1
Lines 319890 319813 -77
Branches 20810 20810
==========================================
- Hits 257120 257053 -67
+ Misses 62377 62367 -10
Partials 393 393 |
| queue="incidents", | ||
| silo_mode=SiloMode.REGION, | ||
| ) | ||
| def send_subscriber_notifications(activity_id: int) -> None: |
There was a problem hiding this comment.
I confirmed via sendgrid that we haven't sent one of these in the last 30 days. There are no IncidentActivity rows with a type of comment since 2021, and since user isn't passed to update_incident_status nobody was getting subscribed so we never found a subscriber to execute the code on lines 83 and 84.
saponifi3d
left a comment
saponifi3d
left a comment
There was a problem hiding this comment.
🔴 - awesome! LGTM
Are we using the IncidentActivityType.COMMENT after these changes? if not, can we also remove that from the IncidentActivityType enum?
Remove an unused feature to comment on incidents. This will be replaced with comments on metric issues. This will be followed by PRs to remove usage of the `IncidentSeen` and `IncidentSubscription` models and then they will be removed.
Follow up to #81386 to remove usages of the `IncidentSeen` and `IncidentSubscription` models before dropping them.
Remove an unused feature to comment on incidents. This will be replaced with comments on metric issues.
This will be followed by PRs to remove usage of the
IncidentSeenandIncidentSubscriptionmodels and then they will be removed.