ref(workflow-engine): migration changes #81602
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
❌ 843 Tests Failed:
View the top 3 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
saponifi3d
reviewed
Dec 3, 2024
|
|
||
| created_by_id = HybridCloudForeignKey(settings.AUTH_USER_MODEL, null=True, on_delete="SET_NULL") | ||
|
|
||
| frequency = models.IntegerField(default=DEFAULT_FREQUENCY) |
Contributor
There was a problem hiding this comment.
fyi, we removed this from the other db migration because this only applies to issue alerts, instead we can make a subclass an ad the frequency to the config property.
Here's a link to that discussion: #80710 (comment) / why it wasn't added.
Member
Author
There was a problem hiding this comment.
oh i missed that, thanks!
Member
Author
|
we can put this in the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workflowfrequency, which corresponds to Rule frequency aka how often an issue alert fires for a group