Skip to content

Conversation

@ceorourke
Copy link
Member

The final follow up to #81605 to drop the IncidentSeen and IncidentSubscription tables.

@ceorourke ceorourke requested a review from a team as a code owner December 3, 2024 21:49
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 3, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

This PR has a migration; here is the generated SQL for src/sentry/migrations/0801_drop_incidentseen_incidentsubscription.py ()

--
-- Delete model IncidentSeen
--
DROP TABLE "sentry_incidentseen" CASCADE;
--
-- Delete model IncidentSubscription
--
DROP TABLE "sentry_incidentsubscription" CASCADE;

@codecov
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #81623      +/-   ##
==========================================
+ Coverage   80.36%   80.44%   +0.08%     
==========================================
  Files        7241     7241              
  Lines      321658   321658              
  Branches    20824    20824              
==========================================
+ Hits       258490   258768     +278     
+ Misses      62768    62490     -278     
  Partials      400      400              

@ceorourke ceorourke force-pushed the ceorourke/drop-incidentseen-incidentsubscription branch from 3a7303f to 20d1f56 Compare December 4, 2024 00:12
@ceorourke ceorourke merged commit f860ea0 into master Dec 4, 2024
49 checks passed
@ceorourke ceorourke deleted the ceorourke/drop-incidentseen-incidentsubscription branch December 4, 2024 17:33
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants