-
-
Couldn't load subscription status.
- Fork 4.5k
deps(sdk): Bump Sentry SDK to9.0.0-alpha.2
#84602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In #84258 we had another change in here on line 52: https://github.com/getsentry/sentry/pull/84527/files#diff-f98c1a5c1c796b62748e96195ba841d106f288cb657aed9b5d1fb31dcd6a2a37
- profilesSampler: ({transactionContext}) => {
+ profilesSampler: samplingContext => {it got reverted in #84527 so i suspect we need to get samplingContext back in there now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JonasBa refactored this file in the meanwhile to remove that sampler so I don't think we should add it back. (?)
9.0.0-alpha.19.0.0-alpha.2
Bundle ReportChanges will increase total bundle size by 25.55kB (0.08%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: app-webpack-bundle-array-pushAssets Changed:
Files in
Files in
|
Reimplements #84258 after it was reverted in #84527. The revert was due to some http/https changes inside the
SentryInstrumentationplugin.