Skip to content

Conversation

@lforst
Copy link
Contributor

@lforst lforst commented Feb 5, 2025

Reimplements #84258 after it was reverted in #84527. The revert was due to some http/https changes inside the SentryInstrumentation plugin.

@lforst lforst requested a review from a team as a code owner February 5, 2025 15:05
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 5, 2025
Copy link
Member

@ryan953 ryan953 Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #84258 we had another change in here on line 52: https://github.com/getsentry/sentry/pull/84527/files#diff-f98c1a5c1c796b62748e96195ba841d106f288cb657aed9b5d1fb31dcd6a2a37

- profilesSampler: ({transactionContext}) => {
+ profilesSampler: samplingContext => {

it got reverted in #84527 so i suspect we need to get samplingContext back in there now.

Copy link
Contributor Author

@lforst lforst Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JonasBa refactored this file in the meanwhile to remove that sampler so I don't think we should add it back. (?)

@lforst lforst changed the title deps(sdk): Bump Sentry SDK to9.0.0-alpha.1 deps(sdk): Bump Sentry SDK to9.0.0-alpha.2 Feb 6, 2025
@codecov
Copy link

codecov bot commented Feb 6, 2025

Bundle Report

Changes will increase total bundle size by 25.55kB (0.08%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 33.19MB 25.55kB (0.08%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: app-webpack-bundle-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
chunks/vendors-node_modules_emotion_styled_base_dist_emotion-styled-base_browser_esm_js-node_modules-0f7219.*.js (New) 1.56MB 1.56MB 100.0% 🚀
chunks/app_actionCreators_discoverHomepageQueries_tsx-app_bootstrap_initializeApp_tsx-app_components-2ddc8c.*.js 11.71kB 1.38MB 0.85%
chunks/vendors-node_modules_emotion_react_jsx-runtime_dist_emotion-react-jsx-runtime_browser_esm_js--98d7e4.*.js (New) 960.18kB 960.18kB 100.0% 🚀
chunks/vendors-node_modules_base64-arraybuffer_dist_base64-arraybuffer_es5_js-node_modules_classname-b86057.*.js -3.57kB 642.15kB -0.55%
chunks/vendors-node_modules_date-fns_format_index_js-node_modules_downsample_methods_ASAP_js-node_mo-9e2918.*.js -2 bytes 555.31kB -0.0%
chunks/app_actionCreators_onboardingTasks_tsx-app_actionCreators_redirectToProject_tsx-app_actionCre-bc1371.*.js (New) 453.38kB 453.38kB 100.0% 🚀
chunks/app_views_issueDetails_groupEventDetails_groupEventDetails_tsx-app_views_issueDetails_streaml-b468ad.*.js 10.56kB 376.62kB 2.88%
chunks/vendors-node_modules_classnames_index_js-node_modules_lodash_debounce_js-node_modules_lodash_-bf5b2d.*.js (New) 307.89kB 307.89kB 100.0% 🚀
chunks/app_actionCreators_guides_tsx-app_actionCreators_preferences_tsx-app_components_avatar_actorA-95b65d.*.js 3.83kB 295.01kB 1.31%
chunks/app_views_dashboards_dashboard_tsx-app_views_metrics_constants_tsx-data_image_svg_xml_base64_-91a9a4.*.js -118 bytes 280.16kB -0.04%
chunks/app_components_events_eventEntries_tsx.*.js 85 bytes 252.14kB 0.03%
chunks/app_components_panels_panelHeader_tsx-app_utils_profiling_hooks_useVirtualizedTree_useVirtual-888b54.*.js 318 bytes 155.22kB 0.21%
chunks/app_views_issueDetails_groupDetails_tsx.*.js -2.37kB 127.97kB -1.82%
chunks/app_data_timezones_tsx-app_utils_useUserTeams_tsx-app_views_alerts_builder_builderBreadCrumbs-058413.*.js 547 bytes 123.73kB 0.44%
chunks/app_components_events_interfaces_crashContent_stackTrace_rawContent_tsx-app_utils_useProjectF-cf9c7e.*.js 64 bytes 117.72kB 0.05%
chunks/app_views_performance_landing_widgets_components_widgetChartRow_tsx-app_views_performance_table_tsx.*.js -3 bytes 113.15kB -0.0%
chunks/app_views_explore_charts_confidenceFooter_tsx-app_views_insights_database_utils_getIntervalFo-e39af7.*.js 797 bytes 110.77kB 0.72%
entrypoints/app.js 111 bytes 98.63kB 0.11%
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_projectDetail_index_tsx.f6c66c7ec71b834379db.js (New) 94.64kB 94.64kB 100.0% 🚀
chunks/app_views_performance_traceDetails_index_tsx.*.js 732 bytes 94.0kB 0.78%
chunks/app_components_events_interfaces_spans_header_tsx-app_components_events_interfaces_spans_wate-4d4c7c.*.js 31 bytes 66.13kB 0.05%
chunks/app_components_breadcrumbs_tsx-app_components_feedback_widget_us*kWidget_tsx-app_utils-df50cf.694979a4fca27c98e15e.js (New) 57.23kB 57.23kB 100.0% 🚀
chunks/app_components_charts_releaseSeries_tsx-app_components_charts_transparentLoadingMask_tsx-app_-8804ec.*.js (New) 53.47kB 53.47kB 100.0% 🚀
chunks/app_components_charts_releaseSeries_tsx-app_components_charts_transparentLoadingMask_tsx-app_-2752ca.*.js (New) 48.4kB 48.4kB 100.0% 🚀
chunks/app_views_stories_index_tsx.*.js 53 bytes 40.85kB 0.13%
chunks/app_components_charts_releaseSeries_tsx-app_components_charts_transparentLoadingMask_tsx-app_-08918c.*.js (New) 39.28kB 39.28kB 100.0% 🚀
chunks/app_components_charts_releaseSeries_tsx-app_components_charts_transparentLoadingMask_tsx-app_-aa0a25.*.js (New) 39.15kB 39.15kB 100.0% 🚀
chunks/app_components_charts_eventsRequest_tsx-app_components_feedback_widget_us*kWidget_tsx--64a49b.c98c3a1960142be5fd6b.js (New) 37.82kB 37.82kB 100.0% 🚀
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_performance_transactionSummary-51d702.cb57ea430afd91761024.js (New) 37.27kB 37.27kB 100.0% 🚀
chunks/app_components_charts_transparentLoadingMask_tsx-app_components_charts_useChartZoom_tsx-app_c-d835d4.*.js (New) 36.58kB 36.58kB 100.0% 🚀
chunks/app_components_charts_releaseSeries_tsx-app_components_charts_transparentLoadingMask_tsx-app_-ab0879.*.js (New) 35.75kB 35.75kB 100.0% 🚀
chunks/app_components_alertLink_tsx-app_views_monitors_components_detailsSidebar_tsx-app_views_monit-813273.*.js 10 bytes 33.05kB 0.03%
chunks/app_views_dashboards_widgets_widgetLayout_widgetLayout_stories_tsx.*.js -202 bytes 32.06kB -0.63%
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_insights_common_components_cha-d2aaf9.b5daedd5944a08ad3c91.js (New) 31.93kB 31.93kB 100.0% 🚀
chunks/app_actionCreators_monitors_tsx-app_components_checkInTimeline_hooks_useTimeWindowConfig_tsx--eb1e58.*.js -872 bytes 29.09kB -2.91%
chunks/app_views_dashboards_contexts_widgetSyncContext_stories_tsx.*.js -484 bytes 28.92kB -1.65%
chunks/vendors-node_modules_moment-timezone_index_js-node_modules_query-string_index_js-node_modules-c3aedd.*.js -737 bytes 28.73kB -2.5%
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-feae7d.fb18fb4977c204aea200.js (New) 24.18kB 24.18kB 100.0% 🚀
chunks/app_icons_icons_stories_tsx.*.js 422 bytes 23.21kB 1.85%
chunks/app_views_insights_browser_resources_components_resourceSize_tsx-app_views_insights_colors_ts-97449f.*.js -229 bytes 22.41kB -1.01%
chunks/app_components_stories_jsxNode_tsx-app_components_stories_jsxProperty_tsx-app_components_stor-253fb5.*.js -118 bytes 22.11kB -0.53%
chunks/app_views_alerts_rules_uptime_details_tsx-node_modules_react-virtualized_dist_es_CellMeasurer-6d1558.*.js 3.43kB 21.99kB 18.47% ⚠️
chunks/app_components_charts_lineChart_tsx-app_views_explore_multiQueryMode_index_tsx.*.js 1.97kB 21.14kB 10.28% ⚠️
chunks/app_views_insights_common_components_insightsLineChartWidget_tsx-app_views_insights_common_qu-a73dd3.*.js -347 bytes 19.93kB -1.71%
chunks/app_components_checkInTimeline_checkInTimeline_tsx-app_components_checkInTimeline_gridLines_t-a9dd19.*.js (New) 19.74kB 19.74kB 100.0% 🚀
chunks/app_components_feedback_widget_us*kWidget_tsx-app_utils_discover_discoverQuery_tsx-app-c5fefe.1f65806a5ba0c483b657.js (New) 17.11kB 17.11kB 100.0% 🚀
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_gridEditable_sortLink_tsx-d372f4.896f07827799dbe2d02c.js (New) 16.21kB 16.21kB 100.0% 🚀
chunks/app_components_charts_lineChart_tsx-app_components_gridEditable_sortLink_tsx-app_utils_discov-25c33b.*.js 305 bytes 15.13kB 2.06%
chunks/app_views_dashboards_widgets_lineChartWidget_lineChartWidget_stories_tsx.*.js -354 bytes 14.29kB -2.42%
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-f61270.cc3e337744dff8bd5cff.js (New) 13.36kB 13.36kB 100.0% 🚀
chunks/app_views_dashboards_widgets_areaChartWidget_areaChartWidget_stories_tsx.*.js -448 bytes 12.59kB -3.44%
chunks/app_views_dashboards_widgets_bigNumberWidget_bigNumberWidget_tsx.*.js -60 bytes 12.35kB -0.48%
chunks/app_components_charts_lineChart_tsx-app_components_feedback_widget_us*kWidget_tsx-app_-26fc43.f77b08315b7a216fe2e0.js (New) 12.25kB 12.25kB 100.0% 🚀
chunks/app_actionCreators_prompts_tsx-app_components_feedback_widget_us*k_tsx-app_components_-5240c4.5e1becb63cbb4a708fbe.js (New) 12.12kB 12.12kB 100.0% 🚀
chunks/app_utils_duration_intervalToMilliseconds_tsx-app_views_insights_common_components_metricRead-56ef6e.*.js (New) 11.73kB 11.73kB 100.0% 🚀
chunks/app_views_dashboards_widgets_common_widgetFrame_tsx.*.js 14 bytes 11.71kB 0.12%
chunks/app_views_dashboards_widgets_barChartWidget_barChartWidget_stories_tsx.*.js -444 bytes 9.55kB -4.44%
chunks/app_components_checkInTimeline_hooks_useTimeWindowConfig_tsx-app_views_insights_uptime_compon-1fd65a.*.js -872 bytes 9.06kB -8.78%
chunks/app_components_checkInTimeline_checkInTimeline_stories_tsx-node_modules_react-aria_utils_dist-e8eb1e.*.js -832 bytes 9.01kB -8.45%
chunks/app_views_dashboards_widgets_common_widgetFrame_stories_tsx.*.js 101 bytes 8.94kB 1.14%
chunks/app_views_settings_components_settingsNavigation_tsx.*.js 59 bytes 8.18kB 0.73%
chunks/app_views_feedback_index_tsx.*.js 860 bytes 3.35kB 34.48% ⚠️
chunks/app_components_nav_secondary_stories_tsx.*.js 55 bytes 3.25kB 1.72%
chunks/app_views_explore_navigation_tsx.*.js 56 bytes 3.12kB 1.82%
chunks/app_views_traces_index_tsx.*.js 857 bytes 2.94kB 41.06% ⚠️
chunks/app_views_projects_index_tsx.*.js 868 bytes 2.74kB 46.32% ⚠️
chunks/app_views_discover_index_tsx.*.js 875 bytes 2.73kB 47.09% ⚠️
chunks/app_views_insights_navigation_tsx.*.js 57 bytes 2.63kB 2.22%
chunks/app_views_profiling_index_tsx.*.js 863 bytes 2.53kB 51.8% ⚠️
chunks/app_views_replays_index_tsx.*.js 859 bytes 2.03kB 73.11% ⚠️
chunks/app_views_releases_index_tsx.*.js (New) 1.78kB 1.78kB 100.0% 🚀
chunks/app_views_dashboards_navigation_tsx.*.js (New) 1.75kB 1.75kB 100.0% 🚀
chunks/vendors-node_modules_emotion_styled_base_dist_emotion-styled-base_browser_esm_js-node_modules-bb29ff.*.js (Deleted) -1.56MB 0 bytes -100.0% 🗑️
chunks/vendors-node_modules_emotion_react_jsx-runtime_dist_emotion-react-jsx-runtime_browser_esm_js--106b1c.*.js (Deleted) -962.79kB 0 bytes -100.0% 🗑️
chunks/app_actionCreators_onboardingTasks_tsx-app_actionCreators_redirectToProject_tsx-app_actionCre-23ad5f.*.js (Deleted) -455.0kB 0 bytes -100.0% 🗑️
chunks/vendors-node_modules_classnames_index_js-node_modules_lodash_debounce_js-node_modules_lodash_-0bc2e8.*.js (Deleted) -307.49kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_projectDetail_index_tsx.214a7e611e4c23a6de4b.js (Deleted) -94.63kB 0 bytes -100.0% 🗑️
chunks/app_components_breadcrumbs_tsx-app_components_feedback_widget_us*kWidget_tsx-app_utils-df50cf.a31a0cbd57efd8476439.js (Deleted) -57.17kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_releaseSeries_tsx-app_components_charts_transparentLoadingMask_tsx-app_-21d9ad.*.js (Deleted) -53.24kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_releaseSeries_tsx-app_components_charts_transparentLoadingMask_tsx-app_-c352e5.*.js (Deleted) -48.17kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_releaseSeries_tsx-app_components_charts_transparentLoadingMask_tsx-app_-7dd784.*.js (Deleted) -39.05kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_releaseSeries_tsx-app_components_charts_transparentLoadingMask_tsx-app_-ccaa4c.*.js (Deleted) -38.92kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_eventsRequest_tsx-app_components_feedback_widget_us*kWidget_tsx--64a49b.64bc596858d7d1bc5bb0.js (Deleted) -37.82kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_performance_transactionSummary-51d702.dff068bb79bd39fd6a13.js (Deleted) -37.27kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_transparentLoadingMask_tsx-app_components_charts_useChartZoom_tsx-app_c-9d1081.*.js (Deleted) -36.35kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_releaseSeries_tsx-app_components_charts_transparentLoadingMask_tsx-app_-f7e414.*.js (Deleted) -35.52kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_views_insights_common_components_cha-d2aaf9.dc09358349dbb42bf7c3.js (Deleted) -31.93kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-feae7d.35c168a3a15c1d055e11.js (Deleted) -24.18kB 0 bytes -100.0% 🗑️
chunks/app_components_checkInTimeline_checkInTimeline_tsx-app_components_checkInTimeline_gridLines_t-34069f.*.js (Deleted) -18.71kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_utils_discover_discoverQuery_tsx-app-c5fefe.a3e484febf58ab281be3.js (Deleted) -17.11kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_gridEditable_sortLink_tsx-d372f4.08c5d32f77a464921f3a.js (Deleted) -16.21kB 0 bytes -100.0% 🗑️
chunks/app_components_feedback_widget_us*kWidget_tsx-app_components_performance_transactionSe-f61270.780a5d9a84af613d530b.js (Deleted) -13.36kB 0 bytes -100.0% 🗑️
chunks/app_components_charts_lineChart_tsx-app_components_feedback_widget_us*kWidget_tsx-app_-26fc43.d529787fba05341ee7dd.js (Deleted) -12.25kB 0 bytes -100.0% 🗑️
chunks/app_actionCreators_prompts_tsx-app_components_feedback_widget_us*k_tsx-app_components_-5240c4.2c9974e8e5d99be34e28.js (Deleted) -12.12kB 0 bytes -100.0% 🗑️
chunks/app_views_insights_common_components_metricReadout_tsx-app_views_insights_common_components_r-74b0c7.*.js (Deleted) -11.5kB 0 bytes -100.0% 🗑️

Files in chunks/app_actionCreators_discoverHomepageQueries_tsx-app_bootstrap_initializeApp_tsx-app_components-2ddc8c.*.js:

  • ./app/utils/performanceForSentry/index.tsx → Total Size: 18.73kB

Files in chunks/app_actionCreators_guides_tsx-app_actionCreators_preferences_tsx-app_components_avatar_actorA-95b65d.*.js:

  • ./app/utils/performanceForSentry/index.tsx → Total Size: 18.73kB

@lforst lforst merged commit 190a7ee into master Feb 6, 2025
42 checks passed
@lforst lforst deleted the lforst-sdk-9.0.0-alpha.1 branch February 6, 2025 12:13
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants