chore(grouping): Add Unreal test cases #85452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just the test cases without adding any rules to improve the experience.
github-actions
bot
added
Scope: Frontend
This comment was marked as resolved.
This comment was marked as resolved.
armenzg
removed
the
Scope: Frontend
armenzg
commented
Feb 19, 2025
| source: tests/sentry/grouping/test_variants.py | ||
| --- | ||
| app: | ||
| hash: null |
There was a problem hiding this comment.
There's no app hash (as expected).
| source: tests/sentry/grouping/test_variants.py | ||
| --- | ||
| app: | ||
| hash: null |
There was a problem hiding this comment.
There's no app hash (as expected).
| source: tests/sentry/grouping/test_variants.py | ||
| --- | ||
| app: | ||
| hash: null |
There was a problem hiding this comment.
There's no app hash (as expected).
github-actions
bot
added
the
Scope: Frontend
armenzg
removed
the
Scope: Frontend
armenzg
commented
Feb 19, 2025
| stacktrace* | ||
| frame* | ||
| function* | ||
| "RtlUserThreadStart" |
There was a problem hiding this comment.
In this file, this frame is shown at the top.
In the UI (link to issue) shows at the bottom:
In the grouping config section matches what we see in this file (at the top):
lobsterkatie
approved these changes
Feb 19, 2025
armenzg
added a commit
that referenced
this pull request
Feb 21, 2025
This will not change system hashes, thus, we can deploy it without a project transition. It's based on #85452. This PR introduces stack trace rules specific to Unreal Engine. Having these set by default will allow us to merge getsentry/sentry-unreal#744 and resolve getsentry/sentry-unreal#669. Essentially, the suggested set of rules addresses grouping issues we encountered with assertion/ensure events. It also cuts off redundant call stack frames for regular events sent via the UE SDK interface. Original rules by @tustanivsky . Supersedes: * #83813
Jesse-Box
pushed a commit
that referenced
this pull request
Feb 21, 2025
This will not change system hashes, thus, we can deploy it without a project transition. It's based on #85452. This PR introduces stack trace rules specific to Unreal Engine. Having these set by default will allow us to merge getsentry/sentry-unreal#744 and resolve getsentry/sentry-unreal#669. Essentially, the suggested set of rules addresses grouping issues we encountered with assertion/ensure events. It also cuts off redundant call stack frames for regular events sent via the UE SDK interface. Original rules by @tustanivsky . Supersedes: * #83813
armenzg
added a commit
that referenced
this pull request
Feb 25, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just the test cases without adding any rules to improve the experience.
Extracted from these: