fix(plugins): show Configure/View on legacy plugin depending on project access #90881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
scttcper
approved these changes
May 5, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 12, 2025
…ct access (#90881) Unlike integrations, plugins (legacy integrations) have project level access. This PR adjusts UI to reflect that considering team level roles as well. Affects two views: - projectPlugins: http://localhost:8000/settings/abc/projects/python-flask/plugins/ - pluginDetailedView: http://localhost:8000/settings/abc/plugins/redmine/?tab=configurations This is not a security fix but a frontend bug fix. # Example A member has these team-level roles: <img width="656" alt="image" src="https://github.com/user-attachments/assets/b2f439d4-c51d-4b7b-a7a2-342fb480cfd1" /> ## projectPlugins **Before.** There is no link on "Configure plugin". <img width="897" alt="image" src="https://github.com/user-attachments/assets/1abfb051-4cea-4b6e-a272-fe2c579bf554" /> **After.** Team contributor has read project-level access to `python-flask` project, hence "View plugin": <img width="897" alt="image" src="https://github.com/user-attachments/assets/82be309f-6d12-4731-a81b-65a7cfdadfee" /> ## pluginDetailedView **Before.** Both "Configure" button links are unavailable: <img width="897" alt="image" src="https://github.com/user-attachments/assets/171d1f33-d919-48c8-9086-68e74713a12e" /> **After.** "Configure" is shown as the user has write permissions on `go` project, and "View" because of the read permissions on `python-flask` project. <img width="897" alt="image" src="https://github.com/user-attachments/assets/5417cdae-562a-4d2c-93f7-9c5dde45594d" />
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike integrations, plugins (legacy integrations) have project level access. This PR adjusts UI to reflect that considering team level roles as well.
Affects two views:
This is not a security fix but a frontend bug fix.
Example
A member has these team-level roles:
projectPlugins
Before. There is no link on "Configure plugin".
After. Team contributor has read project-level access to
python-flaskproject, hence "View plugin":pluginDetailedView
Before. Both "Configure" button links are unavailable:
After. "Configure" is shown as the user has write permissions on
goproject, and "View" because of the read permissions onpython-flaskproject.