ref(charts): Move ECharts options as top level component props #9652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyvg
commented
Sep 6, 2018
| const DEFAULT_TRUNCATE_LENGTH = 80; | ||
|
|
||
| // Truncates labels for tooltip | ||
| function truncateLabel(seriesName, truncate) { |
Member
Author
There was a problem hiding this comment.
These functions are moved from app/organizationDiscover/result/utils
lynnagara
reviewed
Sep 7, 2018
| return moment(value).format('MMM D, YYYY'); | ||
| } | ||
|
|
||
| function getFormatter({filterEmpty, filterNull, filter, isGroupedByDate, truncate}) { |
Member
There was a problem hiding this comment.
I'd vote to drop filterEmpty and filterNull since you can easily pass a filter function that does the same. I think there's value in keeping this API simple.
This moves some properties out of the `options` object that is passed to ECharts, into a top level component property of BaseChart. This allows us to implement more default functionality into BaseChart (e.g. charting a line series for `previousPeriod`).
billyvg
force-pushed
the
ref/charts/start-breakout-of-echarts-options
branch
from
9502d14 to
34e0c52
Compare
lynnagara
approved these changes
Sep 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves some properties out of the
optionsobject that is passed to ECharts, into a top level component property of BaseChart.This allows us to implement more default functionality into BaseChart
(e.g. charting a line series for
previousPeriod).isGroupedByDatetoBaseChartso that we can move formatting logic into charting componentsseriesinto a top level property inBaseChartso that we can add logic to support a Line series forpreviousPeriod.xAxis,yAxis,tooltip,grid