fix(tempest): Only use credentials of active orgs #99101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #99101 +/- ##
=======================================
Coverage 81.21% 81.21%
=======================================
Files 8584 8584
Lines 380166 380169 +3
Branches 24106 24106
=======================================
+ Hits 308747 308754 +7
+ Misses 71073 71069 -4
Partials 346 346 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| @patch("sentry.tempest.tasks.poll_tempest_crashes") | ||
| def test_poll_tempest_no_latest_id( | ||
| self, mock_poll_crashes: MagicMock, mock_fetch_latest: MagicMock | ||
| self, mock_poll_crashes: MagicMock, mock_fetch_latest: MagicMock, mock_has_access: MagicMock |
Contributor
There was a problem hiding this comment.
Bug: Mock Parameter Order Mismatch
The parameter order in test methods using multiple @patch decorators is reversed. Python applies patch decorators from bottom to top, so the outermost decorator's mock object (e.g., mock_has_access) should be the first parameter. This mismatch causes incorrect mock assignments and test configurations.
Additional Locations (2)
vgrozdanic
approved these changes
Sep 15, 2025
tobias-wilfert
deleted the
tobias-wilfert/fix/only-use-credentials-if-org-has-acess
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there might be some credentials in the DB of orgs that don't have access ATM we need to check for that.