Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion static/app/gettingStartedDocs/android/android.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -616,7 +616,7 @@ const profilingOnboarding: OnboardingConfig<PlatformOptions> = {
{
type: StepType.VERIFY,
description: t(
'To confirm that profiling is working correctly, run your application and check the Sentry profiles page for the collected profiles.'
'Verify that profiling is working correctly by simply using your application.'
),
},
],
Expand Down
1 change: 0 additions & 1 deletion static/app/gettingStartedDocs/php/laravel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,6 @@ const profilingOnboarding: OnboardingConfig = {
description: t(
'Verify that profiling is working correctly by simply using your application.'
),
configurations: [],
},
],
nextSteps: () => [],
Expand Down
1 change: 0 additions & 1 deletion static/app/gettingStartedDocs/php/php.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,6 @@ const profilingOnboarding: OnboardingConfig = {
description: t(
'Verify that profiling is working correctly by simply using your application.'
),
configurations: [],
},
],
nextSteps: () => [],
Expand Down
1 change: 0 additions & 1 deletion static/app/gettingStartedDocs/php/symfony.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,6 @@ SENTRY_DSN="${params.dsn.public}"
description: t(
'Verify that profiling is working correctly by simply using your application.'
),
configurations: [],
},
],
nextSteps: () => [],
Expand Down
9 changes: 8 additions & 1 deletion static/app/gettingStartedDocs/python/awslambda.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,14 @@ logger.error('Something went wrong')`,
const profilingOnboarding: OnboardingConfig = {
install: () => [installStep()],
configure: (params: Params) => [configureStep(params)],
verify: () => [],
verify: () => [
{
type: StepType.VERIFY,
description: t(
'Verify that profiling is working correctly by simply using your application.'
),
},
],
};

const logsOnboarding = getPythonLogsOnboarding();
Expand Down
15 changes: 14 additions & 1 deletion static/app/gettingStartedDocs/python/tryton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -174,9 +174,22 @@ logger.error('Something went wrong')`,

const logsOnboarding = getPythonLogsOnboarding();

const profilingOnboarding: OnboardingConfig = {
install: onboarding.install,
configure: onboarding.configure,
verify: () => [
{
type: StepType.VERIFY,
description: t(
'Verify that profiling is working correctly by simply using your application.'
),
},
],
};

const docs: Docs = {
onboarding,
profilingOnboarding: onboarding,
profilingOnboarding,
crashReportOnboarding: crashReportOnboardingPython,
agentMonitoringOnboarding,
logsOnboarding,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ const getReactNativeProfilingOnboarding = (): OnboardingConfig => ({
{
type: StepType.VERIFY,
description: t(
'To confirm that profiling is working correctly, run your application and check the Sentry profiles page for the collected profiles.'
'Verify that profiling is working correctly by simply using your application.'
),
},
],
Expand Down
9 changes: 8 additions & 1 deletion static/app/gettingStartedDocs/ruby/ruby.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,14 @@ end
],
},
],
verify: () => [],
verify: () => [
{
type: StepType.VERIFY,
description: t(
'Verify that profiling is working correctly by simply using your application.'
),
},
],
});

const getInstallSnippet = (params: Params) =>
Expand Down
9 changes: 8 additions & 1 deletion static/app/utils/gettingStartedDocs/dotnet.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -170,5 +170,12 @@ export const getDotnetProfilingOnboarding = ({
),
},
],
verify: () => [],
verify: () => [
{
type: StepType.VERIFY,
description: t(
'Verify that profiling is working correctly by simply using your application.'
),
},
],
});
4 changes: 2 additions & 2 deletions static/app/utils/gettingStartedDocs/javascript.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ export const getJavascriptProfilingOnboarding = <
{
type: StepType.VERIFY,
description: t(
'To confirm that profiling is working correctly, run your application and check the Sentry profiles page for the collected profiles.'
'Verify that profiling is working correctly by simply using your application.'
),
},
],
Expand Down Expand Up @@ -532,7 +532,7 @@ Sentry.startSpan({
{
type: StepType.VERIFY,
description: t(
'To confirm that profiling is working correctly, run your application and check the Sentry profiles page for the collected profiles.'
'Verify that profiling is working correctly by simply using your application.'
),
},
],
Expand Down
9 changes: 1 addition & 8 deletions static/app/views/profiling/onboarding.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import {StepTitles} from 'sentry/components/onboarding/gettingStartedDoc/step';
import {
DocsPageLocation,
ProductSolution,
StepType,
type Configuration,
type DocsParams,
type OnboardingStep,
Expand Down Expand Up @@ -315,13 +314,7 @@ export function Onboarding() {
const steps = [
...profilingDocs.install(docParams),
...profilingDocs.configure(docParams),
// TODO(aknaus): Move into snippets once all have profiling docs
{
type: StepType.VERIFY,
description: t(
'Verify that profiling is working correctly by simply using your application.'
),
},
...profilingDocs.verify(docParams),
];

return (
Expand Down
Loading