fix(aci): Quiet Redis exception noise #99955
Conversation
github-actions
bot
added
the
Scope: Backend
saponifi3d
left a comment
saponifi3d
left a comment
There was a problem hiding this comment.
lgtm, would be awesome to have a few unit tests as another form of documentation.
| yield | ||
|
|
||
|
|
||
| @contextmanager |
There was a problem hiding this comment.
🤔 - think it would be helpful for one of us to give a brown bag on this? (contextmanager)
There was a problem hiding this comment.
Sure, it's an important tool in the toolbox. If it's not known, sharing that it exists (and maybe ContextVars?) would be helpful.
|
|
||
|
|
||
| @contextmanager | ||
| def set_sentry_exception_levels( |
There was a problem hiding this comment.
mind adding a quick test file for this?
There was a problem hiding this comment.
I had one, and I deleted it because it was a lot of mocks talking to mocks. The Sentry SDK doesn't offer much for validating internal behavior, so I pivoted to just reproducing the reporting situation with a global 'before_send' hook that logs to prove to myself it would do as expected.
I'll add in a basic test though.
Issues attributed to commits in this pull requestThis pull request was merged and Sentry observed the following issues: Did you find this useful? React with a 👍 or 👎 |
The redis client code we use internally reports exceptions that occur during resharding that are handled, and that's noisy.
We can contextually set these to be 'info' and avoid the false impression that something is going wrong.