fix(rate limiter) Add table rate limiter to every relevant table#2053
Merged
Conversation
evanh
approved these changes
Aug 12, 2021
Codecov Report
@@ Coverage Diff @@
## master #2053 +/- ##
=======================================
Coverage 91.25% 91.25%
=======================================
Files 506 506
Lines 22001 22004 +3
=======================================
+ Hits 20076 20079 +3
Misses 1925 1925
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is still not ideal as it is per table but there are multiple tables per cluster.
Though better than relying on the global rate limit.
The next step will be to actually make it parametric so different storages can use the same cluster