Skip to content

ref(config): Create Metrics Org Counters Entity yaml file#3646

Merged
enochtangg merged 3 commits into
masterfrom
enoch/add-org_counters_entity_yaml
Jan 26, 2023
Merged

ref(config): Create Metrics Org Counters Entity yaml file#3646
enochtangg merged 3 commits into
masterfrom
enoch/add-org_counters_entity_yaml

Conversation

@enochtangg

Copy link
Copy Markdown
Contributor

This PR is responsible for creating the metrics org_counters entity yaml file using the python_2_yaml conversion script.

@enochtangg enochtangg requested a review from a team as a code owner January 24, 2023 20:29

@evanh evanh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please test again once #3645 is merged.

@codecov

codecov Bot commented Jan 26, 2023

Copy link
Copy Markdown

Codecov Report

Base: 92.16% // Head: 92.16% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (5cb70e6) compared to base (e798987).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3646   +/-   ##
=======================================
  Coverage   92.16%   92.16%           
=======================================
  Files         745      745           
  Lines       34479    34480    +1     
=======================================
+ Hits        31776    31777    +1     
  Misses       2703     2703           
Impacted Files Coverage Δ
tests/datasets/configuration/test_entity_loader.py 97.67% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@enochtangg enochtangg merged commit 9d37bb4 into master Jan 26, 2023
@enochtangg enochtangg deleted the enoch/add-org_counters_entity_yaml branch January 26, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants