fix(issues): resolve u32/u64 group_first_seen bug #7397
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshFerge
approved these changes
Sep 8, 2025
JoshFerge
reviewed
Sep 8, 2025
Member
JoshFerge
left a comment
JoshFerge
left a comment
There was a problem hiding this comment.
would it be possible to add a test for this?
Contributor
Author
|
It seems like the proper way to test things like this is through the snapshot system — I can look into adding the group_first_seen field to the snapshots as a followup, but that'll be in a different repo (I believe the snapshots live in |
|
I recently set up ingestion for group_first_seen. This column is defined as `DateTime`. When I set up the rust processor, I was basing my processing on the `datetime` field, since I knew that the two were sent over identically from `sentry/**/eventstream/snuba.py`. This included using the `StringToIntDatetime64` deserializer, which I still believe is correct. Unfortunately I followed that 64 further than I should've and set the field to be a `u64` in the row — when it should've been a `u32`. This PR fixes that to make future ingestions correct. (I based my changes on the `timestamp` field's parsing, which is similarly a `DateTime` (no 64) column.)
thetruecpaul
force-pushed
the
cpaul/fix/issuefirstseen3264
branch
from
20a8b59 to
dd3a433
Compare
phacops
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently set up ingestion for group_first_seen. This column is defined as
DateTime.When I set up the rust processor, I was basing my processing on the
datetimefield, since I knew that the two were sent over identically fromsentry/**/eventstream/snuba.py. This included using theStringToIntDatetime64deserializer, which I still believe is correct. Unfortunately I followed that 64 further than I should've and set the field to be au64in the row — when it should've been au32.This PR fixes that to make future ingestions correct. (I based my changes on the
timestampfield's parsing, which is similarly aDateTime(no 64) column.)