feat(cbrs): Snuba Admin UI (webpage) #7399

xurui-c · 2025-09-09T19:53:59Z

codecov · 2025-09-10T17:59:36Z

✅ All tests passed

xurui-c · 2025-09-11T03:18:26Z

snuba/admin/static/api_client.tsx

  runMigration: (req: RunMigrationRequest) => Promise<RunMigrationResult>;
  getAllowedTools: () => Promise<AllowedTools>;
  getStoragesWithAllocationPolicies: () => Promise<string[]>;
+  getRoutingStrategies: () => Promise<string[]>,


This endpoint is used for the dropdown, right now we only have 1 strat

xurui-c · 2025-09-11T03:20:26Z

snuba/admin/static/api_client.tsx

+  getRoutingStrategies: () => Promise<string[]>,
  getAllocationPolicies: (storage: string) => Promise<AllocationPolicy[]>;
-  setAllocationPolicyConfig: (
+  getRoutingStrategyConfigs: (strategy_name: string) => Promise<StrategyData>;


This endpoint retrieves all of the strategy configurations as well as the allocation policies, so I don't know if getRoutingStrategyConfigs is the best name - I'm open to other suggestions

xurui-c · 2025-09-11T03:28:25Z

snuba/admin/static/api_client.tsx

  getAllocationPolicies: (storage: string) => Promise<AllocationPolicy[]>;
-  setAllocationPolicyConfig: (
+  getRoutingStrategyConfigs: (strategy_name: string) => Promise<StrategyData>;
+  setConfigurableComponentConfiguration: (


The content of setAllocationPolicyConfig and deleteAllocationPolicyConfig is no longer specific to allocation policy anymore so I changed their names to setConfigurableComponentConfiguration and deleteConfigurableComponentConfiguration

xurui-c · 2025-09-11T03:33:00Z

snuba/admin/static/capacity_management/types.tsx

-};

-type AllocationPolicyConfig = {
+type Configuration = {


This isn't really specific to AllocationPolicy anymore - a configuration is a configuration, so I changed the names in this file accordingly

xurui-c · 2025-09-11T03:36:39Z

snuba/admin/static/capacity_management/types.tsx

  edit: ReactNode;
 };

+type ConfigurableComponentData = {


These mirror the ConfigurableComponentData, PolicyData, and StrategyData in the backend

xurui-c · 2025-09-11T05:29:16Z

snuba/admin/static/capacity_management/policy_renderer.tsx

I decided to keep this file in /capacity_management because allocation policies are originally a CapMan concpet

xurui-c · 2025-09-11T17:59:01Z

snuba/admin/capacity_management_utils.py

we don't need this anymore: #7346 (comment) 🦅 🦅 🦅

xurui-c · 2025-09-11T18:41:08Z

snuba/admin/static/capacity_management/edit_config_modal.tsx

+        deleteOrReset().toLowerCase() +
+        " this config?"


auto-reformatting

xurui-c · 2025-09-11T18:42:36Z

snuba/admin/static/capacity_management/policy_renderer.tsx

+export function PolicyRenderer({ api, policies, resourceIdentifier, resourceType }: PolicyRendererProps) {
+  function renderPolicies(policies: AllocationPolicy[]) {
+    if (!resourceIdentifier) {
+      return <p>{resourceType} not selected.</p>;


I'm also down to have this as return <p>Resource not selected.</p>; so we don't have to have an extra parameter resourceType

xurui-c · 2025-09-11T18:44:28Z

snuba/admin/static/tests/capacity_management/table_color.spec.tsx

-    },
+  name: "key1",
+  value: "10",
+  description: "something",


auto-reformat

xurui-c · 2025-09-11T19:44:38Z

snuba/admin/static/capacity_management/policy_renderer.tsx

+  resourceType: string;
+}
+
+const policyTypeStyle = {


I'm going to change this to ConfigurableComponentTypeStyle

volokluev · 2025-09-11T20:57:21Z

snuba/admin/static/shared/render_configurable_component.tsx

+  renderContent: (data: T | undefined, selectedResource: string | undefined) => React.ReactNode;
+}
+
+function ConfigurableComponentRenderer<T>({


this is more of a dropdown renderer, it has nothing to do with configurable component

xurui-c · 2025-09-15T02:57:23Z

snuba/admin/static/configurable_component/configurable_component_configurations.tsx

I tried to make a new file after renaming but git still recognize the renaming instead

volokluev

Looks good overall, have some comments you can resolve in this PR or a different one

volokluev · 2025-09-16T17:26:13Z

snuba/admin/static/capacity_management/policy_renderer.tsx

+  resourceType: string;
+}
+
+const policyTypeStyle = {


volokluev · 2025-09-16T17:33:37Z

snuba/admin/static/configurable_component/configurable_component_configurations.tsx

+  if (configurableComponentData.configurable_component_namespace === "BaseRoutingStrategy") {
+    return COLORS.SNUBA_BLUE;
+  }


I think you could probably rewrite this logic to be more generic. I.e. if there is no is_active or is_enforced config, the table color is blue. I don't think you need to have this conditional specific to the routing strategies in this generic component

volokluev · 2025-09-16T17:37:19Z

snuba/web/rpc/storage_routing/routing_strategies/outcomes_based.py

                description="Placeholder for now",
                value_type=int,
                default=50,
+                param_types={"organization_id": int},


Not for this PR but a follow up here would be to put the configurations that exist in this strategy (i.e. everywhere that we use get_config in this class, to use the configuration instead

Rachel Chen added 3 commits September 10, 2025 09:47

c

5290d95

noticed a problem

17750f6

namespaced

ff2a13a

xurui-c force-pushed the rachel/frontend branch from aa7f5f4 to ff2a13a Compare September 10, 2025 17:46

Rachel Chen added 3 commits September 10, 2025 11:07

frontend test

9fe050a

add new and refacctor

7790484

tests

8255d78

xurui-c changed the title c feat(cbrs): Snuba Admin UI (webpage) Sep 11, 2025

xurui-c commented Sep 11, 2025

View reviewed changes

Rachel Chen added 2 commits September 10, 2025 20:54

blue

93ccf38

poicy renderer

7ad89a9

xurui-c commented Sep 11, 2025

View reviewed changes

Rachel Chen added 4 commits September 11, 2025 10:01

tests

3a33200

get rid print

986e8e5

colors

c9eb196

remove convert

cd7af1c

xurui-c commented Sep 11, 2025

View reviewed changes

snuba/admin/capacity_management_utils.py

Copy link

Member Author

xurui-c Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need this anymore: #7346 (comment) 🦅 🦅 🦅

DRY

c303581

xurui-c force-pushed the rachel/frontend branch from 35a9f43 to c303581 Compare September 11, 2025 18:03

imports

bc19000

xurui-c commented Sep 11, 2025

View reviewed changes

xurui-c marked this pull request as ready for review September 11, 2025 19:50

xurui-c requested review from a team as code owners September 11, 2025 19:50

volokluev reviewed Sep 11, 2025

View reviewed changes

Rachel Chen added 2 commits September 11, 2025 14:11

shared -> configurable component

01310fa

allocation_policy.tsx -> configurable_component_configurations.tsx

5f780f0

xurui-c force-pushed the rachel/frontend branch from 3d9e20a to 5f780f0 Compare September 12, 2025 20:24

Rachel Chen added 4 commits September 12, 2025 15:37

new file

03abc78

newfilepls

f919071

i can't make it a new file

20af168

documenttion

0ab80a5

xurui-c commented Sep 15, 2025

View reviewed changes

dropdown renderer

aefddcb

xurui-c requested a review from volokluev September 15, 2025 17:40

volokluev approved these changes Sep 16, 2025

View reviewed changes

generic logic

e917cf8

xurui-c enabled auto-merge (squash) September 16, 2025 18:56

xurui-c merged commit f3949b2 into master Sep 16, 2025
34 checks passed

xurui-c deleted the rachel/frontend branch September 16, 2025 19:11

Copilot AI mentioned this pull request Dec 23, 2025

Add SE2 performance review summary for CBRS project contributions #7610

Closed

Uh oh!

feat(cbrs): Snuba Admin UI (webpage) #7399

feat(cbrs): Snuba Admin UI (webpage) #7399

Conversation

xurui-c commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xurui-c Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

volokluev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

xurui-c commented Sep 9, 2025 •

edited

Loading

codecov bot commented Sep 10, 2025 •

edited

Loading

xurui-c Sep 11, 2025 •

edited

Loading