chore: add metric to see how many GetTrace request have a user provided limit #7521
Conversation
| ) | ||
| else: | ||
| self.metrics.increment( | ||
| "eap_trace_request_without_limit", 1, tags={"referrer": in_msg.meta.referrer} |
There was a problem hiding this comment.
should the second argument here be 0?
There was a problem hiding this comment.
no because they are 2 different metrics
There was a problem hiding this comment.
no because they are 2 different metrics
got it, I think you should not bother with the "limit not present" metric. because that should always be count(total requests) - count(limit present requests)
There was a problem hiding this comment.
Why not make this one metric with a different tag for limit/no limit? Is it easier to have 2 metrics?
I don't know if I'd ask them to make a change then tell them to undo that change. I'd ask them to change and agree on a date by when you'd enable this. With the metrics you're adding, you'd be able to track down which referrer is not querying with a limit and tell them to update and at some point, you'll just enable that for good. |
I am beginning to rollout GetTrace endpoint pagination, see this PR. Right now the user must opt-in to pagination by providing a limit. Eventually we would like to enforce a global max limit that is always enforced, but before we can do that we need all of our users to be ready to support pagination. I.e. they need to be able to handle receiving the results in multiple pages.
I will tell product to add this support, and then begin sending a
limitin their request. Once all user queries contain alimit, I can enable global max.