gocd: split pipelines, leaving original, update migration check script #7525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onewland
commented
Nov 11, 2025
| checks: { | ||
| elastic_profile_id: 'snuba', | ||
| environment_variables: { | ||
| PIPELINE_FIRST_STEP: 'deploy-snuba-py-s4s', |
Contributor
Author
There was a problem hiding this comment.
other than this line (and some renames) this is essentially a copy of snuba.libsonnet
onewland
commented
Nov 11, 2025
| checks: { | ||
| elastic_profile_id: 'snuba', | ||
| environment_variables: { | ||
| PIPELINE_FIRST_STEP: 'deploy-snuba-rs-s4s', |
Contributor
Author
There was a problem hiding this comment.
other than this line (and some renames) this is essentially a copy of snuba.libsonnet
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
phacops
approved these changes
Nov 11, 2025
scripts/fetch_service_refs.py
Outdated
| if "pipeline-complete" in stage_status_dict: | ||
| return stage_status_dict["pipeline-complete"] == "Passed" | ||
| else: | ||
| return all(status == "Passed" for status in stage_status_dict.values()) |
Contributor
There was a problem hiding this comment.
You slightly changed this to include the migrate stage in the result from before.
I think we should just keep the result of the pipeline-complete stage and call it a day.
onewland
deleted the
gocd/split-pipelines-leaving-original-update-script
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deploying #7510, we encountered a couple problems.
First was that we were checking the health of a pipeline that we deleted (snuba was removed to be replaced with snuba-rs and snuba-py). This was addressed in #7523 which made snuba-py and snuba-rs check the s4s deploys for those pipelines, respectively.
We then found, however, that
checkswas checking if every stage in a pipeline had executed successfully. We could force bypass this to make a deploy happen, but there was a circular dependency here wherecheckscould only succeed oncecheckshad succeeded. So here I've changedscripts/fetch_service_refs.pyto makecheckssucceed as long as we reach thepipeline-completestage of a region successfully. So the first deploy will have to manually bypasschecksstill but future deploys should proceed unimpeded.In order to reduce gocd-change-deploy thrash, I'm reintroducing the original pipeline (#7510 deleted it while standing up the new ones), which I'm hoping we can just leave paused as we work out remaining kinks. But it eliminates the need to revert if we see any problems
Once we're deploying successfully on the new pipelines we can delete the files: