feat(get_traces): use cross item query path for single item query #7656
+119
−221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volokluev
force-pushed
the
cross_item_one_path
branch
from
d1dae79 to
88ecb2b
Compare
volokluev
force-pushed
the
cross_item_one_path
branch
from
013ff4b to
87185e6
Compare
phacops
approved these changes
Jan 26, 2026
| trace_item_filters_expression, | ||
| f.equals(column("item_type"), item_type), | ||
| ), | ||
| # order_by=[OrderBy(OrderByDirection.DESC, column("trace_id"))], |
Contributor
There was a problem hiding this comment.
We probably can remove this?
Contributor
|
revert failed (conflict? already reverted?) -- check the logs |
volokluev
added a commit
that referenced
this pull request
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Unifies single-item and cross-item query execution paths by using SQL subqueries instead of fetching trace IDs in separate queries. This simplifies the codebase and improves performance by letting ClickHouse optimize the subquery internally.
Changes
get_trace_ids_for_cross_item_query()function that fetched trace IDs in a separate queryget_trace_ids_sql_for_cross_item_query()to return both SQL string and query result for metadata extractionEndpointGetTracesto use subquery approach via_execute_with_subquery_optimization()DangerousRawSQLuse_cross_item_path_for_single_item_queriesto enable unified path for all queries (not just cross-item)Benefits
🤖 Generated with Claude Code