feat: debugger support for consumers, local metrics support, bugbear#7818
feat: debugger support for consumers, local metrics support, bugbear#7818
Conversation
kylemumma
commented
Mar 16, 2026
kylemumma
commented
- debugger support for rust consumers: launch.json
- add support for viewing statsd metrics (datadog) locally for debugging: .envrc, rust-envvars, Makefile
- update workspace extensions
- enabled bugbear warnings in vscode (wont block pre-commit). this is a bit stricter linting rules that catch common bad-practices that lead to bugs. We meant to have it enabled all along but it wasnt due to technical bug. Now the warning will appear in vscode, but if u want u can ignore it and it wont block the commit: settings.json
| "editor.formatOnSave": true | ||
| }, | ||
|
|
||
| "python.defaultInterpreterPath": ".venv/bin/python", |
There was a problem hiding this comment.
dont need it, was causing warnings in vscode, it defaults to python
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix prepared fixes for both issues found in the latest run.
- ✅ Fixed: Removing E712 ignore causes latent CI failures
- I restored
E712to the Ruff ignore list so existing boolean-comparison patterns no longer trigger unrelated CI failures on touched files.
- I restored
- ✅ Fixed: Duplicate DOGSTATSD_HOST export in sourced files
- I removed the redundant
DOGSTATSD_HOSTexport from.envrcand kept the single source of truth inscripts/rust-envvars.
- I removed the redundant
Or push these changes by commenting:
@cursor push 6bd4aa8880
Preview (6bd4aa8880)
diff --git a/.envrc b/.envrc
--- a/.envrc
+++ b/.envrc
@@ -26,5 +26,3 @@
PATH_add "${PWD}/.venv/bin"
. scripts/rust-envvars
-
-export DOGSTATSD_HOST='localhost'
diff --git a/pyproject.toml b/pyproject.toml
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -115,6 +115,7 @@
ignore = [
"E501", # line too long (handled by formatter)
"E402", # module level import not at top of file
+ "E712", # comparisons to True/False are common in tests
]
[tool.mypy]This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
| ] | ||
| ignore = [ | ||
| "E203", # whitespace before ':' | ||
| "E266", # too many leading '#' for block comment |
There was a problem hiding this comment.
Removing E712 ignore causes latent CI failures
Medium Severity
Removing E712 (comparison to True/False) from the ruff ignore list without fixing existing violations creates latent CI failures. There are existing == True / == False comparisons in snuba/query/processors/physical/clickhouse_settings_override.py, snuba/query/allocation_policies/__init__.py, and several test files. Since E712's auto-fix is marked "unsafe", ruff check --fix in pre-commit won't correct them — any future PR touching those files will fail CI unexpectedly.
|
|
||
| . scripts/rust-envvars | ||
|
|
||
| export DOGSTATSD_HOST='localhost' |
There was a problem hiding this comment.
Duplicate DOGSTATSD_HOST export in sourced files
Low Severity
DOGSTATSD_HOST='localhost' is exported in both .envrc (line 30) and scripts/rust-envvars (line 31). Since .envrc sources scripts/rust-envvars on line 28, the export in .envrc is redundant. Having the same value defined in two places risks them silently diverging if only one is updated in the future.
Additional Locations (1)
2 participants
