ref(eap-outcomes): add config to change which timestamp to use#7834
Merged
MeredithAnya merged 1 commit intomasterfrom Mar 26, 2026
Merged
ref(eap-outcomes): add config to change which timestamp to use#7834MeredithAnya merged 1 commit intomasterfrom
MeredithAnya merged 1 commit intomasterfrom
Conversation
Member
|
there is a new feature flagging thing made by dev-inra which I think would be a good candidate for this. I'd rather not litter the consumer with options if we don't have to |
volokluev
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the accepted outcomes consumer testing its been hard to compare exact numbers because the
receivedtimestamp we use for outcomes is an internal timestamp that never gets saved with the data, and differs from thetimestampattribute that gets save in the actual eap table.For the sake of testing, I want the option to have the outcomes use the same timestamp. This will help in both verifying the outcomes are correct and also debugging if the counts are off so we can see where the discrepancies might be.