ref: bump sentry-conventions to 0.5.0#7884
Merged
Conversation
Made-with: Cursor
There was a problem hiding this comment.
Pull request overview
Updates sentry-conventions to the latest release to pick up newer attribute metadata/deprecation mappings while keeping Snuba’s existing API usage unchanged.
Changes:
- Bump
sentry-conventionsdependency constraint from>=0.3.0to>=0.5.0. - Regenerate
uv.lockto pinsentry-conventions==0.5.0and update the locked dependency metadata.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
uv.lock |
Updates the locked sentry-conventions package version, wheel URL, and hash to 0.5.0, plus the top-level requires-dist constraint. |
pyproject.toml |
Raises the declared runtime dependency constraint for sentry-conventions to >=0.5.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Test fails are related to #7886 |
kylemumma
approved these changes
Apr 23, 2026
buenaflor
added a commit
that referenced
this pull request
Apr 24, 2026
Two related fixes for coalesced attribute handling: **1. Skip deprecations without a replacement when building coalesce map** The `_build_deprecated_attributes` loop assumed every deprecation has a `replacement`, but `replacement` is optional. For deprecations without a successor, `replacement=None` created a `None` key in `ATTRIBUTES_TO_COALESCE` and grouped unrelated deprecated attributes together. Now only deprecated attributes that define a replacement are included. Refs #7884 **2. Handle coalesced attributes in `exists_filter`** `exists_filter` (`has:` syntax) on coalesced attributes only checked the canonical key, missing v1 spans stored under deprecated keys. In `get_field_existence_expression`, when `attribute_key_to_expression` returns a `coalesce(...)` for attributes with deprecated mappings, the helper `get_subscriptable_field` extracted only the first parameter (canonical key) and generated `mapContains` for just that key — all deprecated alternatives were silently ignored. Added a handler that detects `coalesce` function calls and recursively generates per-parameter existence checks combined with OR. Fixes #7879 --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
buenaflor
added a commit
to getsentry/sentry
that referenced
this pull request
Apr 28, 2026
Bumps `sentry-conventions` from `>=0.3.0` to `>=0.5.0` and refreshes the generated `src/sentry/search/eap/spans/sentry_conventions/deprecated_attributes.json` from the matching upstream tag ([getsentry/sentry-conventions@0.5.0](https://github.com/getsentry/sentry-conventions/releases/tag/0.5.0)). Backend updates: - Preserve Sentry’s legacy `sentry.profile_id` transaction profile attribute, since `0.5.0` now defines `sentry.profiler_id` for continuous profiling. - Relax trace item attribute tests that depended on exact alias counts/pagination offsets after the generated attribute set grew. - (edge case) Keep generated replacement attributes as primary aliases. `0.5.0` adds backfilled replacements such as `db.system -> db.system.name`; because `db.system` matches Sentry’s existing secondary alias `span.system`, the generated replacement could otherwise inherit `secondary_alias=True` and be hidden from EAP attribute metadata. ## Related `sentry-conventions` bump in Snuba: getsentry/snuba#7884 --------- Co-authored-by: GPT-5.5 <noreply@openai.com>
3 tasks
cleptric
pushed a commit
to getsentry/sentry
that referenced
this pull request
May 5, 2026
Bumps `sentry-conventions` from `>=0.3.0` to `>=0.5.0` and refreshes the generated `src/sentry/search/eap/spans/sentry_conventions/deprecated_attributes.json` from the matching upstream tag ([getsentry/sentry-conventions@0.5.0](https://github.com/getsentry/sentry-conventions/releases/tag/0.5.0)). Backend updates: - Preserve Sentry’s legacy `sentry.profile_id` transaction profile attribute, since `0.5.0` now defines `sentry.profiler_id` for continuous profiling. - Relax trace item attribute tests that depended on exact alias counts/pagination offsets after the generated attribute set grew. - (edge case) Keep generated replacement attributes as primary aliases. `0.5.0` adds backfilled replacements such as `db.system -> db.system.name`; because `db.system` matches Sentry’s existing secondary alias `span.system`, the generated replacement could otherwise inherit `secondary_alias=True` and be hidden from EAP attribute metadata. ## Related `sentry-conventions` bump in Snuba: getsentry/snuba#7884 --------- Co-authored-by: GPT-5.5 <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps `sentry-conventions` from 0.3.0 to 0.5.0 (latest), via `uv lock --upgrade-package sentry-conventions`.
Changelog: https://github.com/getsentry/sentry-conventions/blob/main/CHANGELOG.md
Made with Cursor