Skip to content

feat(explore): Add support for array in TraceItemDetail and TraceItemTable Endpoints#7890

Merged
manessaraj merged 5 commits intomasterfrom
EAP-447_update_details_trace_item_table_endpoints_to_expose_arrays
Apr 22, 2026
Merged

feat(explore): Add support for array in TraceItemDetail and TraceItemTable Endpoints#7890
manessaraj merged 5 commits intomasterfrom
EAP-447_update_details_trace_item_table_endpoints_to_expose_arrays

Conversation

@manessaraj
Copy link
Copy Markdown
Contributor

Expose Array attributes of EAP items in Trace item details endpoint and Trace Item Table endpoint.

Note

TraceItemTable endpoint converts all array types to string arrays while TraceItemDetail endpoint preserves the types.

@manessaraj manessaraj requested review from a team as code owners April 21, 2026 18:34
@linear-code
Copy link
Copy Markdown

linear-code Bot commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

@onewland onewland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine, I would just see if there's a way we can drop that new _scalar_to_attribute_value method in favor of existing code

Comment thread snuba/web/rpc/__init__.py Outdated
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c4e49f0. Configure here.

Comment thread snuba/web/rpc/v1/resolvers/common/trace_item_table.py
@manessaraj manessaraj merged commit 53db24e into master Apr 22, 2026
48 of 49 checks passed
@manessaraj manessaraj deleted the EAP-447_update_details_trace_item_table_endpoints_to_expose_arrays branch April 22, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants