ref(eap-outcomes): dedupe by item_type#7896
Merged
MeredithAnya merged 3 commits intomasterfrom Apr 23, 2026
Merged
Conversation
volokluev
reviewed
Apr 22, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 357dbde. Configure here.
xurui-c
approved these changes
Apr 23, 2026
onewland
reviewed
Apr 23, 2026
onewland
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
seen_itemsandduplicate_item_countinAggregatedOutcomesBatchbyitem_type(HashMap<i32, HashSet<ItemDedupKey>>/HashMap<i32, u64>) so dedup is scoped per item type rather than across all typesis_duplicate(&TraceItem)method onOutcomesAggregator, backed by arecord_if_duplicatemethod onAggregatedOutcomesBatchthat encapsulates both the set insert and the count incrementaccepted_outcomes.duplicate_itemscounter to emit with anitem_typetagTest plan
cargo test is_duplicate_per_item_typepassesaccepted_outcomes.duplicate_itemsmetric now hasitem_typetag in staging🤖 Generated with Claude Code