ref: Rebuild the client with vite and updated deps #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyvg
approved these changes
Oct 11, 2024
Member
billyvg
left a comment
billyvg
left a comment
There was a problem hiding this comment.
how do we test if it builds/deploys properly?
ryan953
changed the title
Member
Author
@billy it builds fine because it's so simple, just put the few component files into a new vite starter template and did have to make a few config changes. It runs locally so i was planning to deploy it and double-check in prod that it works there too, otherwise rollback. the tests that we had were kinda weak, so i didn't port them yet, saves dealing with vitest and testenvs for 2 tests right now. The annoying part is everything inside of the root package.json and makefile that locks the client and server together a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.