Skip to content

Fix(Electron): Electron window dragging and traffic light positioning on macOS#1173

Merged
BYK merged 9 commits intomainfrom
bete/fix/electron-detection
Dec 3, 2025
Merged

Fix(Electron): Electron window dragging and traffic light positioning on macOS#1173
BYK merged 9 commits intomainfrom
bete/fix/electron-detection

Conversation

@betegon
Copy link
Copy Markdown
Member

@betegon betegon commented Dec 2, 2025

We had two issues on macOS Electron app:

  • Window not draggable
  • The close/minimize/maximize buttons were positioned on top of the Spotlight logo in the sidebar

We were checking IN_DESKTOP_ENV which was never set anywhere, so the conditional mt-8 margin were we set the draggable area and the semaphore was place wasn't applied.

I believe this was caused when we merged all packages into the spotlight one.

Screen.Recording.2025-12-02.at.18.28.57.mov

@betegon betegon requested a review from BYK December 2, 2025 17:25
@vercel
Copy link
Copy Markdown

vercel bot commented Dec 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
spotlightjs Skipped Skipped Dec 3, 2025 2:47am

Comment thread packages/spotlight/src/electron/main/index.ts
Comment thread .changeset/bumpy-mugs-kneel.md Outdated
Comment thread packages/spotlight/src/electron/main/index.ts Outdated
Comment thread packages/spotlight/src/ui/lib/Router.tsx
Comment thread packages/spotlight/src/ui/telemetry/components/TelemetryView.tsx Outdated
Comment thread packages/spotlight/src/bootstrap.ts Outdated
@BYK BYK deployed to Preview December 3, 2025 02:19 — with GitHub Actions Active
@BYK BYK deployed to Preview December 3, 2025 02:27 — with GitHub Actions Active
Comment thread packages/spotlight/src/ui/lib/Router.tsx Outdated
Comment thread packages/spotlight/src/ui/lib/Router.tsx
Comment thread packages/spotlight/src/bootstrap.ts Outdated
@BYK BYK merged commit c5cb51f into main Dec 3, 2025
20 checks passed
@BYK BYK deleted the bete/fix/electron-detection branch December 3, 2025 03:17
BYK pushed a commit that referenced this pull request Dec 3, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and publish to npm
yourself or [setup this action to publish
automatically](https://github.com/changesets/action#with-publishing). If
you're not ready to do a release yet, that's fine, whenever you add more
changesets to main, this PR will be updated.


# Releases
## @spotlightjs/spotlight@4.7.0

### Minor Changes

- Add `--allowed-origin` / `-A` CLI option and `allowedOrigins` API
option for configuring additional CORS origins. Supports both full
origins (e.g., `https://ngrok.io:443`) for strict matching and plain
domains (e.g., `myapp.local`) for permissive matching. Fixes
[#1171](#1171).
([#1176](#1176))

### Patch Changes

- Restore draggable electron app and recover semaphore buttons
([#1173](#1173))

- Allow any DNS pointing to localhost in CORS
([#1175](#1175))

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants