Skip to content

enhancement and code refactoring#148

Merged
HazAT merged 3 commits intogetsentry:mainfrom
Shubhdeep12:fix/enhancement-and-refactoring
Nov 28, 2023
Merged

enhancement and code refactoring#148
HazAT merged 3 commits intogetsentry:mainfrom
Shubhdeep12:fix/enhancement-and-refactoring

Conversation

@Shubhdeep12
Copy link
Collaborator

fixes: #147

@vercel
Copy link

vercel bot commented Nov 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spotlightjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 9:27am

Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@HazAT HazAT marked this pull request as ready for review November 28, 2023 09:27
@codecov
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 71 lines in your changes are missing coverage. Please review.

Comparison is base (003ebfd) 32.12% compared to head (4376fad) 32.22%.

Files Patch % Lines
...egrations/sentry/components/Events/Error/Frame.tsx 0.00% 19 Missing ⚠️
...src/integrations/sentry/components/SpanDetails.tsx 0.00% 11 Missing ⚠️
...rc/integrations/sentry/components/TraceDetails.tsx 0.00% 6 Missing ⚠️
...ay/src/integrations/sentry/components/SpanTree.tsx 0.00% 5 Missing ⚠️
packages/overlay/src/components/SidePanel.tsx 0.00% 4 Missing ⚠️
packages/overlay/src/components/Tabs.tsx 0.00% 4 Missing ⚠️
...ntegrations/sentry/components/EventBreadcrumbs.tsx 0.00% 4 Missing ⚠️
...y/src/integrations/sentry/components/EventList.tsx 0.00% 4 Missing ⚠️
...y/src/integrations/sentry/components/TraceList.tsx 0.00% 4 Missing ⚠️
...c/integrations/sentry/components/EventContexts.tsx 0.00% 2 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
+ Coverage   32.12%   32.22%   +0.09%     
==========================================
  Files          34       34              
  Lines        1628     1623       -5     
  Branches       63       63              
==========================================
  Hits          523      523              
+ Misses       1105     1100       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HazAT HazAT merged commit 8eb75ef into getsentry:main Nov 28, 2023
@Shubhdeep12 Shubhdeep12 deleted the fix/enhancement-and-refactoring branch December 4, 2023 13:17
BYK added a commit that referenced this pull request Mar 17, 2026
#1279)

Resolves all 5 open Dependabot alerts for this repo.

## Changes

| Alert | Package | Severity | Action |
|-------|---------|----------|--------|
| #147 | `@modelcontextprotocol/sdk` | **HIGH** | Updated direct dep
`^1.25.2` → `^1.26.0` (resolves to 1.27.1) |
| #142 | `lodash` | **MEDIUM** | Added pnpm override `>=4.17.23` |
| #148 | `qs` | **LOW** | Bumped existing override `>=6.14.1` →
`>=6.14.2` |
| #152 | `svelte` | MEDIUM | Dismissed — unused optional peer dep of
`@vercel/analytics` |
| #153 | `svelte` | MEDIUM | Dismissed — unused optional peer dep of
`@vercel/analytics` |

The svelte alerts were dismissed with reason `not_used` (consistent with
prior dismissals #157, #166) since svelte v4 is only pulled in as an
optional peer dependency of `@vercel/analytics` and the project does not
use Svelte.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code Refactoring and Enhancements

2 participants