Skip to content

fix(sidecar): invalid semver range for source-map#667

Merged
BYK merged 3 commits intogetsentry:mainfrom
belgattitude:fix-sidecar-sourcemap-resolution
Jan 23, 2025
Merged

fix(sidecar): invalid semver range for source-map#667
BYK merged 3 commits intogetsentry:mainfrom
belgattitude:fix-sidecar-sourcemap-resolution

Conversation

@belgattitude
Copy link
Contributor

@belgattitude belgattitude commented Jan 23, 2025

Before opening this PR:

Issue

The range specified isn't technically correct (pnpm accepts this though). Check with semver

image

The fix is simple:

image

Workaround till fixed upstream

  "resolutions": {
    "source-map": ">=0.8.0-beta <0.9.0"
  },

@vercel
Copy link

vercel bot commented Jan 23, 2025

@belgattitude is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@BYK
Copy link
Member

BYK commented Jan 23, 2025

Heya, thanks for the report and the fix! I'll see why there are so many changes in the lock file and approve, merge, release.

@BYK BYK self-requested a review January 23, 2025 20:05
@BYK BYK enabled auto-merge (squash) January 23, 2025 20:06
@vercel
Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spotlightjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 8:09pm

@codecov
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.29%. Comparing base (044d00d) to head (cd306cb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #667   +/-   ##
=======================================
  Coverage   31.29%   31.29%           
=======================================
  Files          92       92           
  Lines        5435     5435           
  Branches      100      100           
=======================================
  Hits         1701     1701           
  Misses       3734     3734           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BYK BYK merged commit 416fecd into getsentry:main Jan 23, 2025
13 of 14 checks passed
BYK pushed a commit that referenced this pull request Jan 24, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and publish to npm
yourself or [setup this action to publish
automatically](https://github.com/changesets/action#with-publishing). If
you're not ready to do a release yet, that's fine, whenever you add more
changesets to main, this PR will be updated.


# Releases
## @spotlightjs/astro@2.4.1

### Patch Changes

-   Updated dependencies \[]:
    -   @spotlightjs/spotlight@2.10.1

## @spotlightjs/electron@1.4.1

### Patch Changes

-   Updated dependencies

\[[`03e386af2024eda44c02952a06433e4d4ecb3356`](03e386a),

[`416fecd778d4829d490b07ec4d500946fa439210`](416fecd)]:
    -   @spotlightjs/overlay@2.10.1
    -   @spotlightjs/sidecar@1.11.1

## @spotlightjs/overlay@2.10.1

### Patch Changes

-   fix: Always try to use sidecar along with direct SDK transport
    ([#672](#672))

## @spotlightjs/sidecar@1.11.1

### Patch Changes

- Fix invalid semver range for source-map dependency
([#667](#667))

## @spotlightjs/spotlight@2.10.1

### Patch Changes

-   Updated dependencies

\[[`03e386af2024eda44c02952a06433e4d4ecb3356`](03e386a),

[`416fecd778d4829d490b07ec4d500946fa439210`](416fecd)]:
    -   @spotlightjs/overlay@2.10.1
    -   @spotlightjs/sidecar@1.11.1

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dcramer pushed a commit that referenced this pull request Jun 3, 2025
Fixes #668 

## Issue

The range specified isn't technically correct (pnpm accepts this though). Check with semver

![image](https://github.com/user-attachments/assets/3f003ad0-85b7-4bc6-bbae-b81d43903496)

The fix is simple:

![image](https://github.com/user-attachments/assets/0908d33c-221c-4b9e-9f2e-d9d2c0e84eab)

## Workaround till fixed upstream

```json5
  "resolutions": {
    "source-map": ">=0.8.0-beta <0.9.0"
  },
```
dcramer pushed a commit that referenced this pull request Jun 3, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and publish to npm
yourself or [setup this action to publish
automatically](https://github.com/changesets/action#with-publishing). If
you're not ready to do a release yet, that's fine, whenever you add more
changesets to main, this PR will be updated.


# Releases
## @spotlightjs/astro@2.4.1

### Patch Changes

-   Updated dependencies \[]:
    -   @spotlightjs/spotlight@2.10.1

## @spotlightjs/electron@1.4.1

### Patch Changes

-   Updated dependencies

\[[`03e386af2024eda44c02952a06433e4d4ecb3356`](03e386a),

[`416fecd778d4829d490b07ec4d500946fa439210`](416fecd)]:
    -   @spotlightjs/overlay@2.10.1
    -   @spotlightjs/sidecar@1.11.1

## @spotlightjs/overlay@2.10.1

### Patch Changes

-   fix: Always try to use sidecar along with direct SDK transport
    ([#672](#672))

## @spotlightjs/sidecar@1.11.1

### Patch Changes

- Fix invalid semver range for source-map dependency
([#667](#667))

## @spotlightjs/spotlight@2.10.1

### Patch Changes

-   Updated dependencies

\[[`03e386af2024eda44c02952a06433e4d4ecb3356`](03e386a),

[`416fecd778d4829d490b07ec4d500946fa439210`](416fecd)]:
    -   @spotlightjs/overlay@2.10.1
    -   @spotlightjs/sidecar@1.11.1

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v2.10.0 - Can't install with yarn

2 participants