build: Use upload-artifacts v4#896
Merged
Merged
Conversation
jjbayer
commented
Feb 4, 2025
| - uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: ${{ github.sha }} | ||
| name: artifact-linux-${{ matrix.build-arch }} |
Member
Author
There was a problem hiding this comment.
Not sure if the name matters here. matrix.target seems to be unavailable so I used matrix.build-arch instead.
szokeasaurusrex
approved these changes
Feb 4, 2025
szokeasaurusrex
left a comment
szokeasaurusrex
left a comment
Member
There was a problem hiding this comment.
Looks reasonable, although you should test this to make sure it works
loewenheim
approved these changes
Feb 4, 2025
loewenheim
left a comment
loewenheim
left a comment
Contributor
There was a problem hiding this comment.
Looks reasonable to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
upload-artifacts v3 is now deprecated and refuses to run.
Cargo-culted this PR off getsentry/ophio#69, I don't know if it will actually work.
#skip-changelog