fix: use goblin permissive PE parse-mode#960
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
fa50088 to
57b5cc4
Compare
57b5cc4 to
600eed0
Compare
jjbayer
left a comment
There was a problem hiding this comment.
@supervacuus could you turn the example you listed in the description into a test in symbolic-debuginfo/tests? Thanks!
Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Added here: 0e8049e |
|
@jjbayer, could we trigger a release for this fix? Then we could bump |
|
@supervacuus I just cut a release with this and #961. |

This is (at least) a partial fix to getsentry/sentry#104738
As the issue above suggests,
goblinwas too strict when parsing strippedPEfiles containing primarilyDWARFdebug sections, because other sections were incomplete. The permissive parse mode has been extended upstream to thePEresource parser, and this update was released withgoblin0.10.5.So this PR
goblinto 0.10.5scrollto align withgoblinManually tested
object_debugagainst the same debug file (and others) as in the issue:Next step: once this is merged and released,
sentry-clishould receive asymbolicbump.