feat: Separate push Taskworker from pull Taskworker#593
Merged
Conversation
Moving the push taskbroker to a k8s Deployment means that the worker logic can simplify. Particularly the push worker doesn't need a list of hosts, just a single service host. Instead of having one Taskworker that supports both modes, create separate classes and clients for each. This meant moving the multiprocess part of the TaskWorker to a separate class, that manages the queues and the various children processes and threads. This class is shared by both the Push worker and the original pull worker. The push-based taskworker doesn't need all the features of the pull based taskbroker. Create a new simpler client that has a single RPC host to connect t
markstory
reviewed
Apr 15, 2026
markstory
approved these changes
Apr 20, 2026
Co-authored-by: Mark Story <mark@mark-story.com>
Co-authored-by: Mark Story <mark@mark-story.com>
…ry/taskbroker into evanh/feat/add-push-mode-workers
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e3eed9a. Configure here.
This was referenced Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Moving the push taskbroker to a k8s Deployment means that the worker logic can simplify. Particularly the push worker doesn't need a list of hosts, just a single service host. Instead of having one Taskworker that supports both modes, create separate classes and clients for each.
This meant moving the multiprocess part of the TaskWorker to a separate class, that manages the queues and the various children processes and threads. This class is shared by both the Push worker and the original pull worker.
The push-based taskworker doesn't need all the features of the pull based taskbroker. Create a new simpler client that has a single RPC host to connect to, that the AlloyDB workers can use.
Note that this should be a non-breaking change: the is being moved around, not changed.