Skip to content

ref(store): Restructure Store Module#594

Merged
george-sentry merged 1 commit intomainfrom
george/spring-cleaning/restructure-store-module
Apr 15, 2026
Merged

ref(store): Restructure Store Module#594
george-sentry merged 1 commit intomainfrom
george/spring-cleaning/restructure-store-module

Conversation

@george-sentry
Copy link
Copy Markdown
Member

Linear

Completes STREAM-875

Description

The store module is not organized very well right now. It's basically centered around one large file, inflight_activation.rs, which mixes together types representing activations, shared helper types, the main store trait, and the SQLite adapter implementation. Meanwhile, the Postgres implementation lives separately in posgres_activation_store.rs.

We need a new layout that makes responsibilities explicit. There should be separate files for core activation types, shared supporting types, traits, adapters, and tests.

Changes

  • Move store trait into store/traits.rs (plural because I plan to break this apart into smaller traits in the future)
  • Move activation and activation status types into store/activation.rs
  • Move shared supporting types like BucketRange and DepthCounts into store/types.rs
  • Move Postgres and SQLite implementations into store/adapters module
  • Keep tests in store/tests.rs
  • Update all imports across the codebase to reference these changes

Note that there should be no changes to behavior. This is mostly just moving code around.

@george-sentry george-sentry requested a review from a team as a code owner April 14, 2026 19:55
@linear-code
Copy link
Copy Markdown

linear-code Bot commented Apr 14, 2026

Copy link
Copy Markdown
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@george-sentry george-sentry merged commit de4c4e0 into main Apr 15, 2026
32 of 33 checks passed
@george-sentry george-sentry deleted the george/spring-cleaning/restructure-store-module branch April 15, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants