ref(store): Restructure Store Module#594
Merged
george-sentry merged 1 commit intomainfrom Apr 15, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear
Completes STREAM-875
Description
The store module is not organized very well right now. It's basically centered around one large file,
inflight_activation.rs, which mixes together types representing activations, shared helper types, the main store trait, and the SQLite adapter implementation. Meanwhile, the Postgres implementation lives separately inposgres_activation_store.rs.We need a new layout that makes responsibilities explicit. There should be separate files for core activation types, shared supporting types, traits, adapters, and tests.
Changes
store/traits.rs(plural because I plan to break this apart into smaller traits in the future)store/activation.rsBucketRangeandDepthCountsintostore/types.rsstore/adaptersmodulestore/tests.rsNote that there should be no changes to behavior. This is mostly just moving code around.