fix(iswf): Reverts change to reporting logic that silences NoRetriesRemaining exceptions#627
Merged
GabeVillalobos merged 1 commit intoMay 13, 2026
Conversation
…emaining exceptions
markstory
reviewed
May 11, 2026
Comment on lines
+284
to
+286
| retry_error = NoRetriesRemainingError( | ||
| f"{inflight.activation.taskname} has consumed all of its retries" | ||
| ) |
Member
There was a problem hiding this comment.
So even for a silenced error we would capture an error when the task has run out of retries and will be discarded 👍
kcons
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reporting is valuable for other teams to triage issues with their tasks and retries, even through silenced exceptions. Knowing when a task has exceeded its maximum number of retries means that the task has effectively transitioned to a terminal state and will not be reattempted if no deadletter is set. While this will increase a bit of noise, it'll provide better ideas of failure rates in our product.