Skip to content

fix: Update to latest sentry-protos version #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
untitaker merged 4 commits into from
May 28, 2026
Merged

fix: Update to latest sentry-protos version #651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8d117fd
fix: Update to latest sentry-protos version
evanh May 28, 2026
d8c238e
uv.lock
evanh May 28, 2026
33fe26d
bump rust too
untitaker May 28, 2026
c1c4f1d
lockfile!
untitaker May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ sentry = { version = "0.41.0", default-features = false, features = [
"tracing",
"logs"
] }
sentry_protos = "0.11.0"
sentry_protos = "0.16.1"
Copy link
Copy Markdown

@sentry sentry Bot May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The code uses .unwrap() on the result of TaskActivation::decode(), which will cause a panic if protobuf deserialization fails due to a schema mismatch.
Severity: HIGH

Suggested Fix

Replace the .unwrap() calls on TaskActivation::decode() with proper error handling. The function should return a Result and propagate the error, or handle it gracefully by logging the error and returning an appropriate gRPC status code or skipping the problematic task.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: Cargo.toml#L47

Potential issue: The result of `TaskActivation::decode()` is unwrapped without handling
the potential `Err` case. If protobuf deserialization fails, for example due to a schema
version mismatch between services during a rolling deployment, the `.unwrap()` call will
cause a panic. This occurs in several production-critical code paths, including the gRPC
handlers for `get_task` and `set_task_status`, as well as in the periodic upkeep
process. A panic in these locations will crash the service, interrupting task processing
and maintenance.

Also affects:

  • src/upkeep.rs:169
  • src/upkeep.rs:569
  • src/upkeep.rs:596
  • src/upkeep.rs:623
  • src/upkeep.rs:675
  • src/upkeep.rs:716
  • src/upkeep.rs:722
  • src/upkeep.rs:1048
  • src/kafka/deserialize_raw.rs:242
  • src/kafka/deserialize_raw.rs:274
  • src/kafka/deserialize_raw.rs:322
  • src/grpc/server.rs:69
  • src/grpc/server.rs:213
  • src/test_utils.rs:423
  • src/test_utils.rs:435

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link
Copy Markdown
Member Author

@untitaker untitaker May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wtf

serde = "1.0.214"
serde_bytes = "0.11"
serde_yaml = "0.9.34"
Expand Down
2 changes: 1 addition & 1 deletion clients/python/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ readme = "README.md"
dependencies = [
"sentry-arroyo>=2.38.7",
"sentry-sdk[http2]>=2.43.0",
"sentry-protos>=0.10.0",
"sentry-protos>=0.15.0",
"confluent_kafka>=2.3.0",
"cronsim>=2.6",
"grpcio>=1.67.0",
Expand Down
2 changes: 1 addition & 1 deletion integration_tests/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ dev = [
"orjson>=3.10.10",
"protobuf>=5.28.3",
"pyyaml>=6.0.2",
"sentry-protos>=0.2.0",
"sentry-protos>=0.15.0",
"flake8>=7.3.0",
"isort>=5.13.2",
"mypy>=1.17.1",
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ dev = [
"orjson>=3.10.10",
"protobuf>=5.28.3",
"pyyaml>=6.0.2",
"sentry-protos>=0.11.0",
"sentry-protos>=0.15.0",
Comment thread
evanh marked this conversation as resolved.
"flake8>=7.3.0",
"isort>=5.13.2",
"mypy>=1.17.1",
Expand Down
10 changes: 5 additions & 5 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading