feat(taskbroker): Batch Claimed to Processing Updates#654
Open
george-sentry wants to merge 4 commits into
Open
feat(taskbroker): Batch Claimed to Processing Updates#654george-sentry wants to merge 4 commits into
george-sentry wants to merge 4 commits into
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
markstory
reviewed
May 29, 2026
|
|
||
| // Make sure we aren't flushing too soon | ||
| let now = Utc::now().timestamp_millis(); | ||
| let elapsed = self.last_flush.timestamp_millis() - now; |
Member
There was a problem hiding this comment.
Shouldn't this be now - last_update?
Comment on lines
+62
to
+65
| let updaterd = tokio::spawn({ | ||
| let updater = updater.clone(); | ||
| async move { updater.start().await } | ||
| }); |
Member
There was a problem hiding this comment.
How do the push threads append to this updater?
Base automatically changed from
george/push-taskbroker/add-push-thread-abstraction
to
main
May 29, 2026 17:31
george-sentry
force-pushed
the
george/push-taskbroker/batched-claimed-to-processing-updates
branch
from
c78e0a7 to
814e9cd
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6d6f61d. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear
Refs STREAM-920
Description
After a "claimed" activation is pushed successfully, it needs to be updated to "processing." Right now this happens one at a time, which is a performance bottleneck. This PR adds optional batching for these updates, which adds several thousand additional tasks per second on my typical testing workload (100 millisecond dummy tasks).
Concerning data loss, what if taskbroker crashes while these updates are queued? Those updates are lost, meaning even though those tasks were claimed and sent successfully, they weren't updated to processing. Three things can happen here...
In all cases, tasks aren't dropped but may be repeated.