Skip to content

Conversation

@hubertdeng123
Copy link
Member

With the revamped devservices, the configurations for how to run taskbroker should live in this repo and not sentry.

See snuba: https://github.com/getsentry/sentry/blob/ec05e95588181966ded878090b1241e3b3fb2775/devservices/config.yml#L6

This allows configurations to be defined in the appropriate repo and be used anywhere else.

@hubertdeng123 hubertdeng123 requested a review from a team December 11, 2024 22:46
taskbroker:
image: ghcr.io/getsentry/taskbroker:latest
environment:
TASKBROKER_KAFKA_CLUSTER: "kafka-kafka-1:9093"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this address get set correctly? I notice it's different from the one defined in snuba, and different from the name of the current kafka devservice (which is called sentry_kafka).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the new devservices command uses different host names. I've also noticed that the devservices container has 9092 exposed instead of 9093.

Copy link
Member Author

@hubertdeng123 hubertdeng123 Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should actually be fine, we're using mostly the same settings as before and taskbroker should be communicating on the docker internal network which should use port 9093 as defined here: https://github.com/getsentry/sentry-shared-kafka/blob/c8ab4ee7627d435c4c5ebccf21c5744950eac1f6/devservices/config.yml#L25.

If taskbroker cannot properly connect to kafka, will it error out anywhere? How can we tell it is properly configured?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, taskbroker will error and crash if it cannot connect to Kafka.

@hubertdeng123 hubertdeng123 merged commit 98d50e3 into main Dec 12, 2024
6 checks passed
@hubertdeng123 hubertdeng123 deleted the hubertdeng123/add-taskbroker-container-devservices branch December 12, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants