feat: authentication support for kafka connection #530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
viglia
reviewed
Dec 12, 2024
| } | ||
| } | ||
|
|
||
| return &kafka.Transport{ |
Contributor
There was a problem hiding this comment.
Don't you need to set a Dialer as well here?
If writer Transport is nil DefaultTransport is used, but in this case it won't as we're explicitly setting it with createKafkaRoundTripper.
I think here we should first create a Transport like here and then set the SASL and TLS?
phacops
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support self-hosted users better by providing auth mechanism for Kafka connections. Introduces a few environment variables:
SENTRY_KAFKA_SASL_MECHANISM(valid values:"PLAIN","SCRAM-SHA-256","SCRAM-SHA-512","")SENTRY_KAFKA_SASL_USERNAMESENTRY_KAFKA_SASL_PASSWORDSENTRY_KAFKA_SSL_CA_PATHSENTRY_KAFKA_SSL_CERT_PATHSENTRY_KAFKA_SSL_KEY_PATHIf the mechanism is not provided, it will default to a nil
kafka.RoundTripper, which is the default already.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.