fix: prevent shell injection in sync-xcodebuildmcp-docs workflow#6
Merged
cameroncooke merged 1 commit intomainfrom Apr 26, 2026
Merged
Conversation
Use environment variable instead of direct interpolation of inputs.ref to prevent potential shell injection attacks. Fixes: https://linear.app/getsentry/issue/ENG-7519 Related: https://linear.app/getsentry/issue/VULN-1565 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a high-severity security finding by preventing potential shell injection in the
sync-xcodebuildmcp-docs.ymlGitHub Actions workflow.Changes
Instead of directly interpolating
${{ inputs.ref }}in the shell command, the value is now stored in an environment variableINPUT_REFand referenced as"$INPUT_REF"in the script. This follows GitHub's security best practices for hardening GitHub Actions.References