-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
Hi @getssh
Your code is awesome. I like how you used separate variables for the links section.
And also you did CSS for the mobile version. But the following suggestions could make more betterments. 🤩
HTML
- Use
headerandh1tag in HTML 😬, as it is more semantic.
Line 10 in 8157903
<h1 class="main-title">Leaderboard</h1> - Use the
sectiontag in HTML here
Line 11 in 8157903
<main class="score-wrapper"> - Using the default
submitoption of forms, instead of directly givingevent listenerto the form button
Line 26 in 8157903
<form action="#" class="add-score-data">
JS
- Showing error by using the
requiredattribute of input, instead of using a JS error.
Leaderboard/src/modules/api.js
Line 1 in 8157903
import showError from './showError.js'; - Returning the
scores.resultdirectly, rather than creating another variable for it. ✌️
Leaderboard/src/modules/api.js
Line 9 in 8157903
const scoreResult = scores.result;
By the way, your code was awesome, Keep grinding !! 💪
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
