Add namespace prefix to lazily-loaded data object#84
Merged
sckott merged 2 commits intogetwilds:mainfrom Feb 5, 2025
Merged
Conversation
Contributor
Author
|
Errors in CI appear to not be from these changes, but due to auth to minio, maybe because I'm on a fork? |
Member
|
thanks @ateucher i'll check |
Member
|
looks like the |
Contributor
Author
|
I'm not sure if they are? empty in this macos run: https://github.com/getwilds/sixtyfour/actions/runs/13039241629/job/36377038930?pr=84#step:2:17 The minio tests are skipped on macos and Windows right? |
Member
|
You're right, minio and localstack are only run on linux CI's |
Member
|
Lets ignore the failures, almost positive its because the secretws arej't avail on PRs, tests and everything else works fine locally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add namespace prefix to
service_mapdata object as it's not in the package namespace.Related Issue
Fixes #83