Sdk 2791 php add support for retrieving the extraction image ids field from the idv pages#409
Conversation
Release/4.4.2
Version update release 4.4.2
There was a problem hiding this comment.
Pull request overview
This PR updates the PHP SDK release metadata and build/test configuration (version bump to 4.5.0, PHP/runtime constraints, dependency updates, and CI matrix adjustments). The changes shown do not currently include the extraction_image_ids / PageResponse parsing support described in the PR title/description.
Changes:
- Bump SDK/package version from 4.4.1 to 4.5.0 (Constants, composer.json, README).
- Tighten PHP requirement to
^8.1and update dependency constraints (notablygoogle/protobufandphpseclib/phpseclib). - Update GitHub Actions unit test jobs to cover PHP 8.1–8.4 with renamed jobs and small workflow cleanups.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/Constants.php |
Updates in-code SDK version constant to 4.5.0. |
README.md |
Updates documented PHP requirement and install snippets to 4.5.0. |
composer.json |
Bumps package version, tightens PHP requirement, updates dependency versions. |
.github/workflows/tests.yaml |
Updates CI job matrix/names and minor formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "name": "yoti/yoti-php-sdk", | ||
| "description": "Yoti SDK for quickly integrating your PHP backend with Yoti", | ||
| "version": "4.4.1", | ||
| "version": "4.5.0", |
There was a problem hiding this comment.
The PR title/description says it adds support for extraction_image_ids on PageResponse, but the diff only updates versions/dependencies/CI and does not modify src/DocScan/Session/Retrieve/PageResponse.php (or any parsing/tests) to expose that field. Please either include the missing PageResponse changes + tests, or update the PR metadata to match what’s actually being changed here.
| "require": { | ||
| "php": "^7.4 || ^8.0 || ^8.1 || ^8.4", | ||
| "php": "^8.1", | ||
| "ext-json": "*", | ||
| "google/protobuf": "^3.10", | ||
| "phpseclib/phpseclib": "^3.0", | ||
| "google/protobuf": "^4.33.6", | ||
| "phpseclib/phpseclib": "^3.0.50", |
There was a problem hiding this comment.
php requirement is being tightened from supporting PHP 7.4/8.0 to ^8.1 only. This is a breaking change for consumers pinned to older runtimes, but the package version is only bumped from 4.4.1 to 4.5.0 (minor). If this project follows semantic versioning, this should be a major version bump (or the breaking support drop should be handled/released according to the repo’s documented versioning policy).
…d-from-the-idv-pages
nikhilPank
left a comment
There was a problem hiding this comment.
LGTM
extractionImageIds showing up in the response
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Summary
extraction_image_idsfield toPageResponseto expose which media was used forautomated extraction