Skip to content

Sdk 2791 php add support for retrieving the extraction image ids field from the idv pages#409

Merged
mehmet-yoti merged 7 commits intodevelopmentfrom
SDK-2791-php-add-support-for-retrieving-the-extraction-image-ids-field-from-the-idv-pages
Apr 8, 2026
Merged

Sdk 2791 php add support for retrieving the extraction image ids field from the idv pages#409
mehmet-yoti merged 7 commits intodevelopmentfrom
SDK-2791-php-add-support-for-retrieving-the-extraction-image-ids-field-from-the-idv-pages

Conversation

@mehmet-yoti
Copy link
Copy Markdown
Contributor

Summary

  • Add extraction_image_ids field to PageResponse to expose which media was used for
    automated extraction
  • Field is parsed as an array of UUID strings, defaults to empty array when absent

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the PHP SDK release metadata and build/test configuration (version bump to 4.5.0, PHP/runtime constraints, dependency updates, and CI matrix adjustments). The changes shown do not currently include the extraction_image_ids / PageResponse parsing support described in the PR title/description.

Changes:

  • Bump SDK/package version from 4.4.1 to 4.5.0 (Constants, composer.json, README).
  • Tighten PHP requirement to ^8.1 and update dependency constraints (notably google/protobuf and phpseclib/phpseclib).
  • Update GitHub Actions unit test jobs to cover PHP 8.1–8.4 with renamed jobs and small workflow cleanups.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/Constants.php Updates in-code SDK version constant to 4.5.0.
README.md Updates documented PHP requirement and install snippets to 4.5.0.
composer.json Bumps package version, tightens PHP requirement, updates dependency versions.
.github/workflows/tests.yaml Updates CI job matrix/names and minor formatting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread composer.json
"name": "yoti/yoti-php-sdk",
"description": "Yoti SDK for quickly integrating your PHP backend with Yoti",
"version": "4.4.1",
"version": "4.5.0",
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title/description says it adds support for extraction_image_ids on PageResponse, but the diff only updates versions/dependencies/CI and does not modify src/DocScan/Session/Retrieve/PageResponse.php (or any parsing/tests) to expose that field. Please either include the missing PageResponse changes + tests, or update the PR metadata to match what’s actually being changed here.

Copilot uses AI. Check for mistakes.
Comment thread composer.json
Comment on lines 11 to +15
"require": {
"php": "^7.4 || ^8.0 || ^8.1 || ^8.4",
"php": "^8.1",
"ext-json": "*",
"google/protobuf": "^3.10",
"phpseclib/phpseclib": "^3.0",
"google/protobuf": "^4.33.6",
"phpseclib/phpseclib": "^3.0.50",
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

php requirement is being tightened from supporting PHP 7.4/8.0 to ^8.1 only. This is a breaking change for consumers pinned to older runtimes, but the package version is only bumped from 4.4.1 to 4.5.0 (minor). If this project follows semantic versioning, this should be a major version bump (or the breaking support drop should be handled/released according to the repo’s documented versioning policy).

Copilot uses AI. Check for mistakes.
Comment thread README.md
@nikhilPank nikhilPank self-requested a review April 7, 2026 13:40
Copy link
Copy Markdown
Contributor

@nikhilPank nikhilPank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
extractionImageIds showing up in the response

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@mehmet-yoti mehmet-yoti merged commit 6acbf1c into development Apr 8, 2026
12 checks passed
@mehmet-yoti mehmet-yoti mentioned this pull request Apr 8, 2026
@mehmet-yoti mehmet-yoti mentioned this pull request Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants