Graph edge search date time filters#266
Merged
paul-paliychuk merged 44 commits intomainfrom Jul 14, 2025
Merged
Conversation
# Conflicts: # examples/chat_history/memory.py
# Conflicts: # pyproject.toml
# Conflicts: # pyproject.toml
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 8ea0111 in 2 minutes and 11 seconds. Click for details.
- Reviewed
190lines of code in7files - Skipped
0files when reviewing. - Skipped posting
7draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. pyproject.toml:3
- Draft comment:
Version bump to 2.18.0 looks good. Consider adding a project description if applicable. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is purely informative about the version bump and suggests updating the project description, which violates the rules about not asking to update the PR description.
2. src/zep_cloud/__init__.py:10
- Draft comment:
New exports (ComparisonOperator and DateFilter) have been added. Verify that any user documentation is updated to reflect these new types. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the PR author to verify that user documentation is updated, which violates the rule against asking the author to ensure or verify things. The comment does not provide a specific suggestion or point out a specific issue with the code.
3. src/zep_cloud/core/client_wrapper.py:20
- Draft comment:
Header version updated to 2.18.0. Ensure this remains consistent with release and documentation. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is about ensuring consistency between the header version and the release/documentation. It is asking the author to ensure consistency, which violates the rule against asking the author to ensure things. Therefore, this comment should not be approved.
4. src/zep_cloud/types/__init__.py:12
- Draft comment:
New type imports for ComparisonOperator and DateFilter are included. This aligns with the new API features. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, providing information about new type imports and their alignment with new API features. It does not offer any suggestions, ask for confirmation, or point out any issues.
5. src/zep_cloud/types/comparison_operator.py:1
- Draft comment:
Auto-generated ComparisonOperator file: including 'typing.Any' in the union effectively weakens type checking. Consider revising if stricter typing is desired. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 0% vs. threshold = 50% Since this is an auto-generated file, any manual modifications would likely be overwritten on the next generation. The type definition comes from an API definition, so changes should be made there instead. Making changes here would be futile and possibly misleading. The comment makes a valid technical point about type safety. Maybe there's a way to configure the generator to produce stricter types? While the technical suggestion is sound, suggesting direct edits to auto-generated files is not the right approach. Any issues should be addressed in the API definition or generator configuration. Delete the comment because it suggests modifying an auto-generated file, which would be overwritten on the next generation.
6. src/zep_cloud/types/date_filter.py:11
- Draft comment:
New DateFilter model added. The 'date' field is typed as a string; consider using a datetime type for better validation if an ISO or similar format is expected. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 0% vs. threshold = 50% Since this is an auto-generated file, any type changes would need to be made in the API definition, not in this file directly. The presence of datetime handling code suggests the string format is intentional for API compatibility. Making changes here would be overwritten on the next generation. The comment identifies a potentially valid concern about type safety. The presence of datetime handling code could indicate this is part of a larger design decision. However, since this is an auto-generated file, suggesting changes here is not actionable - changes would need to be made in the source API definition. Delete the comment because it suggests changes to an auto-generated file, which would be overwritten on the next generation.
7. src/zep_cloud/types/search_filters.py:12
- Draft comment:
New date filter fields (created_at, expired_at, invalid_at, valid_at) have been added with clear docstrings explaining the 2D filter logic. Ensure the example syntax meets user expectations. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative and does not provide any actionable feedback or suggestions for improvement. It violates the rule against making purely informative comments.
Workflow ID: wflow_ME07IOYRNq1Jv9D3
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Adds date filtering capabilities to graph edge searches with new
DateFilterandComparisonOperatortypes, updating version to 2.18.0.DateFilterandComparisonOperatortypes indate_filter.pyandcomparison_operator.pyfor date-based filtering.SearchFiltersinsearch_filters.pyto includecreated_at,expired_at,invalid_at, andvalid_atfields with 2D date filter arrays.pyproject.tomlandclient_wrapper.py.DateFilterandComparisonOperatorto__init__.pyinzep_cloudandtypes.This description was created by
for 8ea0111. You can customize this summary. It will automatically update as commits are pushed.