fix: resolve EC2 instance ID by tag instead of static secret#4
Merged
Conversation
Spot instance replacements change the instance ID, breaking all SSM commands with InvalidInstanceId errors. Replace the static Ec2InstanceId SST secret with a runtime ec2:DescribeInstances lookup filtered by the Role=task-forge-runner tag. Result is cached per Lambda cold start. Falls back to EC2_INSTANCE_ID env var if set. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ec2InstanceIdSST secret with runtimeec2:DescribeInstanceslookup filtered byRole=task-forge-runnertagEC2_INSTANCE_IDenv var if setsst.config.tsMotivation
Spot instance replacements change the instance ID, causing all SSM
SendCommandcalls to fail withInvalidInstanceId. This required manually updating the SST secret and redeploying. With tag-based lookup, new instances are discovered automatically as long as they carry theRole=task-forge-runnertag.Test plan
sst deployMade with Cursor