Blind Fix CMake config file#286
Merged
schuhschuh merged 1 commit intogflags:masterfrom Sep 29, 2019
Merged
Conversation
Fix, when integrating prebuilt gflags as ```cmake set(GFLAGS_USE_TARGET_NAMESPACE TRUE) find_package(gflags COMPONENTS static) ```
Contributor
Author
|
currently I got: cd my_super_project_using_gflags_build
cmake -S. -Bbuild
...
CMake Error at build/dependencies/install/lib/cmake/gflags/gflags-config.cmake:40 (message):
Package gflags was installed without required component static!
Call Stack (most recent call first):
cmake/cpp.cmake:16 (find_package)
CMakeLists.txt:88 (include)note: on my way to test the patch |
Member
|
Looks good. Thanks for catching this and submitting a patch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix, when integrating prebuilt gflags as