Swinging door compression: fix compression to avoid unnecessary datapoints #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` | Method | Mean | Error | StdDev | Ratio | RatioSD | Code Size | |--------- |---------:|----------:|----------:|------:|--------:|----------:| | Current | 4.549 ns | 0.1294 ns | 0.1976 ns | 1.00 | 0.00 | 233 B | | Inlined | 2.993 ns | 0.0969 ns | 0.1294 ns | 0.66 | 0.04 | 178 B | | Inlined1 | 1.915 ns | 0.0748 ns | 0.1208 ns | 0.42 | 0.04 | 129 B | | Inlined2 | 1.219 ns | 0.0608 ns | 0.1016 ns | 0.27 | 0.03 | 102 B | ``` `Inlined2` is implemented now.
gfoidl
commented
Nov 6, 2021
...foidl.DataCompression/Compression/SwingingDoorCompression/SwingingDoorCompressionIterator.cs
Outdated
Show resolved
Hide resolved
2 tasks
gfoidl
force-pushed
the
swinging-door-fix
branch
from
31cacb6 to
c329d2c
Compare
gfoidl
force-pushed
the
swinging-door-fix
branch
from
04724cf to
4444f50
Compare
Owner
Author
|
@FloCD I hope the bug got fixed, can you please give it a try? I pushed a preview-version v2.2.0-preview-1 to the development channel. ./build.sh build
./build.sh pack
# NuGet-package is in ./NuGet-PackedThanks in advance! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Owner
Author
|
/azp run DataCompression-Demos, DataCompression-Benchmarks |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59
Due the common code-path for the core-iteration of deadband and swinging door, there was a bug which recored too much datapoints for the swinging door algorithm. This PR fixes this, by introducing a new property
ArchiveIncomingthat needs to be set on each specific algorithm.The rest of the PR adds more tests, and shuffles some things around.