Skip to content

primitives.js implementation does not match documentation. #345

@Scott-Coleman

Description

@Scott-Coleman

From the lesson, "Drawing Multiple Things", in the source file "primitives.js"...

If I understand the documentation for the "createSphereVertices()" function, it does not match the implementation.

Within the function, the optional parameter "opt_startLatitudeInRadians" is missing from calculation of "phi".

I think the line should be:

const phi = latRange * v + opt_startLatitudeInRadians;

...or by some other mechanism "opt_startLatitudeInRadians" needs to be the starting point for calculation of "phi".

By inspection, a similar issue exists for the computation of "theta"

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions