ui: Remove PWA navigate fallback to prevent caching API endpoint requests - #25174
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the SvelteKit PWA configuration for the UI so the service worker does not interfere with llama serve API endpoints (for example /models, /props, /slots, /v1/models) by routing navigations to index.html.
Changes:
- Removes the previously exported
PWA_KIT_OPTIONS.NAVIGATE_FALLBACKhelper and its usage indevOptions. - Sets a
workbox.navigateFallbackoverride intended to prevent the PWA plugin from adding a navigation fallback route that can affect API endpoints.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1bdc0de to
302c2b4
Compare
302c2b4 to
74c2880
Compare
|
ready for review & testing |
|
I suspected as much; I merged it to my server right after your push --force, and I didn't encounter any regressions with the direct links (settings / conversations) in Firefox:) |
besides the obvious PWA testing path, what needs to be tested manually is entering the |
|
This LGTM, (no address bar to check URL on PWA), quick test OK no problem on install / any pages |
aldehir
left a comment
There was a problem hiding this comment.
Giving approval, won't be available to test for a couple of days.
Picks up the upstream webui fix that stopped the PWA service worker from caching API endpoint requests (ggml-org/llama.cpp#25174).
Removes the navigate fallback setting which caused an unwanted re-routing to index.html after caching it for the
llama serveendpoints like/models,/props,/slotsetc.