Only request VK_KHR_shader_bfloat16 extension if supported - #28155
Conversation
|
Hi @madsmtm, thanks for your contribution! Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:
Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below. |
|
Open an issue with logs and description of what goes wrong instead. |
|
Sure, I've opened #28161. |
|
Thank you, now I understood the problem. Your fix is basically correct, the one thing missing is to remove the duplicated |
e5b507c to
29fed0e
Compare
|
Ofc, I missed that the extension is already added earlier |
…gml-org#28155) (cherry picked from commit 56dd815)
…gml-org#28155) (cherry picked from commit 56dd815)
Overview
My friend's Windows machine has an AMD Radeon(TM) 890M Graphics iGPU which doesn't support bf16.
In some cases though the code will currently still set
device->coopmat_bf16_support = true, which later on causes it to request theVK_KHR_shader_bfloat16extension (even though it isn't reported as supported), and the following error to be reported:This PR adds a
bfloat16_supportcheck to ensure that we don't try to do this ifVK_KHR_shader_bfloat16isn't supported. The fix has been tested by building with this diff applied, and successfully loading the model in this case.Fixes #28161.
Requirements