Skip to content

Add SPM infill support#8016

Merged
slaren merged 4 commits into
ggml-org:masterfrom
CISC:spm-infill-support
Jun 28, 2024
Merged

Add SPM infill support#8016
slaren merged 4 commits into
ggml-org:masterfrom
CISC:spm-infill-support

Conversation

@CISC

@CISC CISC commented Jun 19, 2024

Copy link
Copy Markdown
Member

Add SPM infill (Suffix(Prefix/Middle pattern) support for models like Codestral that require this.

@mofosyne mofosyne added the Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix label Jun 19, 2024
@CISC

CISC commented Jun 26, 2024

Copy link
Copy Markdown
Member Author

@slaren Mind reviewing this one?

@slaren slaren left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not very familiar with this feature, but the code looks good to me.

@slaren
slaren merged commit 38373cf into ggml-org:master Jun 28, 2024
Nexesenex pushed a commit to Nexesenex/croco.cpp that referenced this pull request Jun 30, 2024
* add --spm-infill option

* support --spm-infill

* support --spm-infill
MagnusS0 pushed a commit to MagnusS0/llama.cpp-normistral-tokenizer that referenced this pull request Jul 1, 2024
* add --spm-infill option

* support --spm-infill

* support --spm-infill
Nexesenex pushed a commit to Nexesenex/croco.cpp that referenced this pull request Jul 1, 2024
* add --spm-infill option

* support --spm-infill

* support --spm-infill
@CISC
CISC deleted the spm-infill-support branch August 6, 2024 13:12
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
* add --spm-infill option

* support --spm-infill

* support --spm-infill
ljubomirj pushed a commit to ljubomirj/llama.cpp that referenced this pull request May 6, 2026
* add --spm-infill option

* support --spm-infill

* support --spm-infill
my-other-github-account pushed a commit to my-other-github-account/llama.cpp that referenced this pull request May 15, 2026
* add --spm-infill option

* support --spm-infill

* support --spm-infill
my-other-github-account pushed a commit to my-other-github-account/llama.cpp that referenced this pull request May 15, 2026
* add --spm-infill option

* support --spm-infill

* support --spm-infill
phibya pushed a commit to ziee-ai/llama.cpp that referenced this pull request May 29, 2026
* add --spm-infill option

* support --spm-infill

* support --spm-infill
AlexiAlp pushed a commit to minghaop/llama.cpp that referenced this pull request Jun 2, 2026
* add --spm-infill option

* support --spm-infill

* support --spm-infill
AlexiAlp pushed a commit to minghaop/llama.cpp that referenced this pull request Jun 2, 2026
* add --spm-infill option

* support --spm-infill

* support --spm-infill
fukuro-kun pushed a commit to fukuro-kun/fukuro-llama-cpp-turboquant that referenced this pull request Jul 5, 2026
* add --spm-infill option

* support --spm-infill

* support --spm-infill
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

examples Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants