-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Allow stand-alone build of simple example #1255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
And the next step is to make CMake config actually work. |
slaren
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about this. It would be ok to have an example specifically for this purpose, but just randomly changing one of the examples to be a separate project, without any documentation or explanation in the code, is just going to be confusing.
|
Maybe for now just add the |
|
Well, I just use this example to validate the installed cmake config (and in a variation, pkgconfig) of the vcpkg port. Your CI could do the same. I explicitly tried to find a simple existing example. The additions should not cause much confusion - It is really just very basic CMake, nicely illustrating expected basic usage. |
Helps to validate the installed package.
Proof of concept: dg0yt#1 |
What else would be needed to remove concerns? |
|
Hm, I expected this to be a no-brainer. I wanted this to be merged before updating the ggml-org ports in vcpkg. |
|
... and before upstreaming dg0yt#1. |
|
Create a new very trivial example called |
|
Valid, but obsolete. |
This helps to validate the installed package.
It also shows a benefit of the other change: An in-build
ggml::ggmlALIAS enables a uniform link library name regardless of ggml being used as a sub-project or viafind_package.