Skip to content

fix MSVC build#479

Merged
ggerganov merged 4 commits into
ggml-org:masterfrom
cebtenzzre:fix-msvc
Aug 28, 2023
Merged

fix MSVC build#479
ggerganov merged 4 commits into
ggml-org:masterfrom
cebtenzzre:fix-msvc

Conversation

@cebtenzzre
Copy link
Copy Markdown
Contributor

@cebtenzzre cebtenzzre commented Aug 26, 2023

I am attempting to get ggml to build successfully on MSVC.
This is currently a draft PR because I have not yet resolved these errors:

Resolved errors
tests\test-mul-mat2.c(1661,89): error C2440: 'type cast': cannot convert from '__m256i' to '__m256'
tests\test-mul-mat2.c(1661,28): error C2168: '_mm256_and_ps': too few actual parameters for intrinsic function
tests\test-mul-mat2.c(2049,89): error C2440: 'type cast': cannot convert from '__m256i' to '__m256'
tests\test-mul-mat2.c(2049,28): error C2168: '_mm256_and_ps': too few actual parameters for intrinsic function

I know very little about SIMD intrinsics, so I would appreciate some help with that.

edit: done.

@cebtenzzre cebtenzzre marked this pull request as ready for review August 26, 2023 20:07
@ggerganov ggerganov merged commit 37b5dba into ggml-org:master Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants